Skip to content

Commit b302b1f

Browse files
authored
Change Blog post title from h3 to h1 (#155)
* Change title from h3 to h1 * Raise requirement to ^1.7.0
1 parent cd1d4d3 commit b302b1f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
}
2323
},
2424
"require": {
25-
"flarum/core": "^1.5.0",
25+
"flarum/core": "^1.7.0",
2626
"flarum/tags": "^1.0.0",
2727
"flarum/lock": "^1.0.0",
2828
"ext-json": "*"

js/src/forum/pages/BlogComposer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,15 +195,15 @@ export default class BlogComposer extends Page {
195195

196196
<div className={'FlarumBlog-Article-Post'}>
197197
{/* Article name */}
198-
<h3 onclick={() => this.openNameArticleModal()} className="FlarumBlog-Article-Title" style={{ cursor: 'pointer' }}>
198+
<h1 onclick={() => this.openNameArticleModal()} className="FlarumBlog-Article-Title" style={{ cursor: 'pointer' }}>
199199
{this.article && this.article.title() && this.article.title() !== ''
200200
? this.article.title()
201201
: app.translator.trans('v17development-flarum-blog.forum.composer.no_title')}
202202

203203
<button class="Button Button--text" onclick={(e) => e.preventDefault()}>
204204
<i className={'fas fa-edit'} />
205205
</button>
206-
</h3>
206+
</h1>
207207

208208
<div className="Post-body">
209209
<Composer

js/src/forum/pages/BlogItem.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,14 @@ export default class BlogItem extends Page {
112112

113113
items.add(
114114
'title',
115-
<h3
115+
<h1
116116
className={classList('FlarumBlog-Article-Title', {
117117
'FlarumBlog-Article-GhostTitle': this.loading,
118118
})}
119119
>
120120
{this?.article?.title?.() || 'Ghost title'}
121121
{this.article?.isHidden?.() && `(${app.translator.trans('v17development-flarum-blog.forum.hidden')})`}
122-
</h3>,
122+
</h1>,
123123
100
124124
);
125125

0 commit comments

Comments
 (0)