Skip to content

Commit 87ce94f

Browse files
authored
Fix profile activation for non-apple silicon (elastic#2399)
Relying on <activeByDefault>true</activeByDefault> does not work when a profile, such as the IntelliJ profile is active
1 parent bdbf401 commit 87ce94f

File tree

1 file changed

+22
-3
lines changed

1 file changed

+22
-3
lines changed

apm-agent-plugins/apm-grpc/pom.xml

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,29 @@
4040

4141
<profiles>
4242
<profile>
43-
<id>default</id>
43+
<id>non-mac</id>
4444
<activation>
45-
<activeByDefault>true</activeByDefault>
45+
<os>
46+
<family>!mac</family>
47+
</os>
48+
</activation>
49+
<!-- Keep in sync with mac-non-apple-silicon profile -->
50+
<modules>
51+
<module>apm-grpc-plugin</module>
52+
<module>apm-grpc-test-1.6.1</module>
53+
<!-- other intermediate gRPC versions that have been tested : 1.7.1, 1,9.1, 1.13.2, 1.22.0, 1.23.0, 1.27.1 -->
54+
<module>apm-grpc-test-latest</module>
55+
</modules>
56+
</profile>
57+
<profile>
58+
<id>mac-non-apple-silicon</id>
59+
<activation>
60+
<os>
61+
<family>mac</family>
62+
<arch>!aarch64</arch>
63+
</os>
4664
</activation>
65+
<!-- Keep in sync with non-mac profile -->
4766
<modules>
4867
<module>apm-grpc-plugin</module>
4968
<module>apm-grpc-test-1.6.1</module>
@@ -56,7 +75,7 @@
5675
Old grpc/protobuf compilers don't support mac aarch64 (Apple Silicon, such as M1)
5776
Therefore, excluding apm-grpc-test-1.6.1
5877
-->
59-
<id>apple-silicon</id>
78+
<id>mac-apple-silicon</id>
6079
<activation>
6180
<os>
6281
<family>mac</family>

0 commit comments

Comments
 (0)