integration-server-test: Avoid assert panic and add cleanup-on-failure (elastic#17222)

* Avoid panic when number of indices mismatch

* Add cleanup-on-failure

Author: ericywl

Makefile

@@ -364,28 +364,28 @@ endif
 ifndef SCENARIO
 	$(error SCENARIO is not set)
 endif
-	@cd integrationservertest && go test -run=TestUpgrade.*/.*/$(SCENARIO) -v -timeout=60m -cleanup-on-failure=false -target="pro" -upgrade-path="$(UPGRADE_PATH)" ./
+	@cd integrationservertest && go test -run=TestUpgrade.*/.*/$(SCENARIO) -v -timeout=60m -cleanup-on-failure=true -target="pro" -upgrade-path="$(UPGRADE_PATH)" ./
 
 # Run integration server upgrade test on all scenarios
 .PHONY: integration-server-upgrade-test-all
 integration-server-upgrade-test-all:
 ifndef UPGRADE_PATH
 	$(error UPGRADE_PATH is not set)
 endif
-	@cd integrationservertest && go test -run=TestUpgrade_UpgradePath -v -timeout=60m -cleanup-on-failure=false -target="pro" -upgrade-path="$(UPGRADE_PATH)" ./
+	@cd integrationservertest && go test -run=TestUpgrade_UpgradePath -v -timeout=60m -cleanup-on-failure=true -target="pro" -upgrade-path="$(UPGRADE_PATH)" ./
 
 # Run integration server standalone test on one scenario - Managed7 / Managed8 / Managed9
 .PHONY: integration-server-standalone-test
 integration-server-standalone-test:
 ifndef SCENARIO
 	$(error SCENARIO is not set)
 endif
-	@cd integrationservertest && go test -run=TestStandaloneManaged.*/$(SCENARIO) -v -timeout=60m -cleanup-on-failure=false -target="pro" ./
+	@cd integrationservertest && go test -run=TestStandaloneManaged.*/$(SCENARIO) -v -timeout=60m -cleanup-on-failure=true -target="pro" ./
 
 # Run integration server standalone test on all scenarios
 .PHONY: integration-server-standalone-test-all
 integration-server-standalone-test-all:
-	@cd integrationservertest && go test -run=TestStandaloneManaged -v -timeout=60m -cleanup-on-failure=false -target="pro" ./
+	@cd integrationservertest && go test -run=TestStandaloneManaged -v -timeout=60m -cleanup-on-failure=true -target="pro" ./
 
 ##############################################################################
 # Generating and linting API documentation

integrationservertest/internal/asserts/data_streams.go

@@ -18,6 +18,7 @@
 package asserts
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -81,6 +82,10 @@ func checkSingleDataStream(t *testing.T, expected DataStreamExpectation, actual
 		"data stream %s should have %d indices", actual.Name, len(expected.IndicesManagedBy),
 	)
 	for i, index := range actual.Indices {
+		if i >= len(expected.IndicesManagedBy) {
+			assert.Fail(t, fmt.Sprintf("index %s not in expectation", index.IndexName))
+			continue
+		}
 		assert.Equal(t, expected.IndicesManagedBy[i], index.ManagedBy.Name,
 			`index %s should be managed by "%s"`, index.IndexName,
 			expected.IndicesManagedBy[i],