fix: address Copilot review comments

- Eliminate duplicate categorize_commit function definitions
- Create shared functions file at /tmp/release_functions.sh
- Ensure consistent categorization across GitHub and Google Play notes
- Fix variable scoping for GITHUB_REPOSITORY in functions
- Include all commit types (chore, docs) in both sections

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: graycreate

.github/workflows/release.yml

@@ -350,10 +350,8 @@ jobs:
         GH_TOKEN: ${{ github.token }}
         GITHUB_REPOSITORY: ${{ github.repository }}
       run: |
-        # Get commits since last tag
-        LAST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "")
-        CURRENT_TAG="${{ needs.prepare.outputs.version }}"
-
+        # Define shared functions that will be used in both changelog generation steps
+        cat > /tmp/release_functions.sh << 'FUNCTIONS_EOF'
         # Function to categorize commit message
         categorize_commit() {
           local msg="$1"
@@ -395,13 +393,14 @@ jobs:
         # Function to get GitHub username from commit
         get_github_username() {
           local commit_sha="$1"
+          local github_repo="${GITHUB_REPOSITORY}"
           # Try to get the GitHub username from the commit using gh api
-          local username=$(gh api "repos/${{ github.repository }}/commits/${commit_sha}" --jq '.author.login // empty' 2>/dev/null || echo "")
+          local username=$(gh api "repos/${github_repo}/commits/${commit_sha}" --jq '.author.login // empty' 2>/dev/null || echo "")
           if [ -n "$username" ]; then
             echo "@$username"
           else
             # Fallback: try to get committer login if author login is not available
-            local committer=$(gh api "repos/${{ github.repository }}/commits/${commit_sha}" --jq '.committer.login // empty' 2>/dev/null || echo "")
+            local committer=$(gh api "repos/${github_repo}/commits/${commit_sha}" --jq '.committer.login // empty' 2>/dev/null || echo "")
             if [ -n "$committer" ]; then
               echo "@$committer"
             else
@@ -422,6 +421,14 @@ jobs:
             fi
           fi
         }
+        FUNCTIONS_EOF
+
+        # Source the functions
+        source /tmp/release_functions.sh
+
+        # Get commits since last tag
+        LAST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "")
+        CURRENT_TAG="${{ needs.prepare.outputs.version }}"
 
         # Collect commits and categorize them
         declare -A features
@@ -605,68 +612,12 @@ jobs:
       run: |
         mkdir -p whatsnew
 
+        # Source the shared functions defined earlier
+        source /tmp/release_functions.sh
+
         # Get commits since last tag for categorization
         LAST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "")
 
-        # Function to categorize commit message (same as above)
-        categorize_commit() {
-          local msg="$1"
-          local category=""
-          local cleaned_msg=""
-
-          if [[ "$msg" =~ ^fix(\(.*\))?:\ (.*)$ ]] || [[ "$msg" =~ ^fix\ (.*)$ ]]; then
-            category="bug"
-            cleaned_msg="${BASH_REMATCH[-1]}"
-          elif [[ "$msg" =~ ^feat(\(.*\))?:\ (.*)$ ]] || [[ "$msg" =~ ^feat\ (.*)$ ]]; then
-            category="feature"
-            cleaned_msg="${BASH_REMATCH[-1]}"
-          elif [[ "$msg" =~ ^perf(\(.*\))?:\ (.*)$ ]]; then
-            category="performance"
-            cleaned_msg="${BASH_REMATCH[2]}"
-          elif [[ "$msg" =~ ^refactor(\(.*\))?:\ (.*)$ ]]; then
-            category="improvement"
-            cleaned_msg="${BASH_REMATCH[2]}"
-          else
-            category="other"
-            cleaned_msg="$msg"
-          fi
-
-          # Remove PR numbers from the end
-          cleaned_msg=$(echo "$cleaned_msg" | sed 's/ (#[0-9]*)//')
-
-          # Capitalize first letter
-          cleaned_msg="$(echo "${cleaned_msg:0:1}" | tr '[:lower:]' '[:upper:]')${cleaned_msg:1}"
-
-          echo "$category:$cleaned_msg"
-        }
-
-        # Function to get GitHub username from commit (reuse from above)
-        get_github_username() {
-          local commit_sha="$1"
-          local username=$(gh api "repos/${{ github.repository }}/commits/${commit_sha}" --jq '.author.login // empty' 2>/dev/null || echo "")
-          if [ -n "$username" ]; then
-            echo "@$username"
-          else
-            local committer=$(gh api "repos/${{ github.repository }}/commits/${commit_sha}" --jq '.committer.login // empty' 2>/dev/null || echo "")
-            if [ -n "$committer" ]; then
-              echo "@$committer"
-            else
-              local git_author=$(git show -s --format='%an' $commit_sha)
-              case "$git_author" in
-                "Gray Zhang" | "gray" | "Gray")
-                  echo "@graycreate"
-                  ;;
-                "github-actions[bot]")
-                  echo "@github-actions[bot]"
-                  ;;
-                *)
-                  echo ""
-                  ;;
-              esac
-            fi
-          fi
-        }
-
         # Collect and categorize commits
         declare -A features
         declare -A bugs