Commit 6c7dc8f
fix: Address Copilot review comments for VshareWebActivity
- Fix navigation handling: Return false in shouldOverrideUrlLoading to let WebView handle standard navigation
- Add security settings: Disable file/content access and enable Safe Browsing for API >= 26
- Fix theme switching: Compute URL in onCreate to handle live theme changes
- Remove redundant progress bar logic: Consolidate visibility handling in WebChromeClient
- Optimize cache handling: Use clearCache(false) to avoid purging shared cache
- Fix layout theming: Use app-themed attribute (page_bg_color) instead of android:attr
All issues identified by GitHub Copilot have been addressed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 174d615 commit 6c7dc8f
File tree
2 files changed
+20
-19
lines changed- app/src/main
- res/layout
2 files changed
+20
-19
lines changedLines changed: 19 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
| |||
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | 41 | | |
51 | 42 | | |
52 | 43 | | |
| |||
69 | 60 | | |
70 | 61 | | |
71 | 62 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
76 | 69 | | |
| 70 | + | |
77 | 71 | | |
78 | 72 | | |
79 | 73 | | |
| |||
86 | 80 | | |
87 | 81 | | |
88 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
| |||
102 | 105 | | |
103 | 106 | | |
104 | 107 | | |
105 | | - | |
106 | | - | |
107 | | - | |
| 108 | + | |
| 109 | + | |
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
| |||
116 | 118 | | |
117 | 119 | | |
118 | 120 | | |
119 | | - | |
120 | 121 | | |
121 | 122 | | |
122 | 123 | | |
| |||
153 | 154 | | |
154 | 155 | | |
155 | 156 | | |
156 | | - | |
| 157 | + | |
157 | 158 | | |
158 | 159 | | |
159 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
0 commit comments