Skip to content

Commit b34e685

Browse files
graycreateclaude
andcommitted
fix: address PR review comments from Copilot
- Update Fastfile rollout comment to clarify decimal representation - Remove unused GHUI_ environment variables from release workflow - Fix Play Console URL by removing placeholder developer ID 🤖 Generated with Claude Code (https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent fb187c3 commit b34e685

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,6 @@ jobs:
8585
echo "Key alias configured: ${{ secrets.KEY_ALIAS != '' && 'Yes' || 'No' }}"
8686
8787
- name: Build release APK
88-
env:
89-
GHUI_KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
90-
GHUI_KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
9188
run: |
9289
if [ "${{ vars.ENABLE_SIGNING }}" = "true" ] && [ -f "app/keystore.jks" ]; then
9390
echo "Building signed release APK"
@@ -156,9 +153,6 @@ jobs:
156153
echo "$KEYSTORE_BASE64" | base64 --decode > app/keystore.jks
157154
158155
- name: Build release bundle
159-
env:
160-
GHUI_KEYSTORE_PASSWORD: ${{ secrets.KEYSTORE_PASSWORD }}
161-
GHUI_KEY_PASSWORD: ${{ secrets.KEY_PASSWORD }}
162156
run: |
163157
if [ "${{ vars.ENABLE_SIGNING }}" = "true" ] && [ -f "app/keystore.jks" ]; then
164158
echo "Building signed release bundle"
@@ -364,4 +358,4 @@ jobs:
364358
echo "- **Status**: ${{ steps.release-config.outputs.status }}" >> $GITHUB_STEP_SUMMARY
365359
echo "- **Package**: me.ghui.v2er" >> $GITHUB_STEP_SUMMARY
366360
echo "" >> $GITHUB_STEP_SUMMARY
367-
echo "[View in Play Console](https://play.google.com/console/u/0/developers/your-developer-id/app/me.ghui.v2er)" >> $GITHUB_STEP_SUMMARY
361+
echo "[View in Play Console](https://play.google.com/console/u/0/app/me.ghui.v2er)" >> $GITHUB_STEP_SUMMARY

fastlane/Fastfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ platform :android do
129129
upload_to_play_store(
130130
track: "beta",
131131
track_promote_to: "production",
132-
rollout: "0.1", # Start with 10% rollout
132+
rollout: "0.1", # Start with 10% rollout (0.1 = 10%)
133133
skip_upload_apk: true,
134134
skip_upload_aab: true,
135135
skip_upload_metadata: true,

0 commit comments

Comments
 (0)