Skip to content

Commit c1e0575

Browse files
graycreateclaude
andcommitted
fix: simplify bundletool keystore creation in download-signed-apk
- Remove complex fallback logic that was causing failures - Create debug keystore upfront before calling bundletool - Use simpler keytool command without 2>/dev/null redirection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent a501119 commit c1e0575

File tree

1 file changed

+10
-18
lines changed

1 file changed

+10
-18
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -433,31 +433,23 @@ jobs:
433433
echo "Downloading bundletool..."
434434
wget -q https://github.com/google/bundletool/releases/latest/download/bundletool-all.jar
435435
436-
# Generate universal APK from the AAB (this will have Google Play signing when deployed)
436+
# Create a dummy debug keystore for bundletool (required for APK generation)
437+
echo "Creating dummy keystore..."
438+
keytool -genkey -v -keystore debug.keystore -alias androiddebugkey \
439+
-keyalg RSA -keysize 2048 -validity 10000 \
440+
-dname "CN=Android Debug,O=Android,C=US" \
441+
-storepass android -keypass android
442+
443+
# Generate universal APK from the AAB
437444
echo "Generating universal APK set..."
438445
java -jar bundletool-all.jar build-apks \
439446
--bundle="$AAB_PATH" \
440447
--output=apks.apks \
441448
--mode=universal \
442-
--ks=dummy.keystore \
449+
--ks=debug.keystore \
443450
--ks-pass=pass:android \
444451
--ks-key-alias=androiddebugkey \
445-
--key-pass=pass:android 2>/dev/null || {
446-
# If no keystore, create a dummy one
447-
keytool -genkey -v -keystore dummy.keystore -alias androiddebugkey \
448-
-keyalg RSA -keysize 2048 -validity 10000 \
449-
-dname "CN=Android Debug,O=Android,C=US" \
450-
-storepass android -keypass android 2>/dev/null
451-
452-
java -jar bundletool-all.jar build-apks \
453-
--bundle="$AAB_PATH" \
454-
--output=apks.apks \
455-
--mode=universal \
456-
--ks=dummy.keystore \
457-
--ks-pass=pass:android \
458-
--ks-key-alias=androiddebugkey \
459-
--key-pass=pass:android
460-
}
452+
--key-pass=pass:android
461453
462454
# Extract the universal APK
463455
unzip -q apks.apks universal.apk

0 commit comments

Comments
 (0)