fix the total topic count with thousand separators #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NumberFormatException that occurs when parsing topic counts containing thousand separators (commas) from HTML content. The fix addresses the issue where topic counts like "137,647" would fail to parse as integers.
- Changed data type from
inttoStringfor the raw extracted value - Implemented proper parsing logic to handle comma-separated numbers
- Added exception handling to gracefully handle parsing errors
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| this.items = items; | ||
| } | ||
|
|
||
| public int getTotal() { |
There was a problem hiding this comment.
This method could throw a NullPointerException if totalStr is null. Add a null check before processing the string.
Suggested change
| public int getTotal() { | |
| public int getTotal() { | |
| if (totalStr == null || totalStr.isEmpty()) { | |
| return 0; | |
| } |
| return total; | ||
| try { | ||
| return Integer.parseInt(totalStr.replaceAll("[^0-9]", "")); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Catching generic Exception is too broad. Catch specific exceptions like NumberFormatException or NullPointerException for better error handling and debugging.
Suggested change
| } catch (Exception e) { | |
| } catch (NumberFormatException | NullPointerException e) { |
Member
|
Thank you for your contribution. |
graycreate
added a commit
that referenced
this pull request
Sep 18, 2025
- Rename totalStr to totalCountRaw for better clarity - Add null/empty check before parsing - Use specific NumberFormatException instead of generic Exception - Add error logging for failed parsing attempts - Add descriptive comment explaining the field purpose This is a follow-up to PR #82, implementing improvements suggested by GitHub Copilot review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
graycreate
added a commit
that referenced
this pull request
Sep 18, 2025
…#115) - Rename totalStr to totalCountRaw for better clarity - Add null/empty check before parsing - Use specific NumberFormatException instead of generic Exception - Add error logging for failed parsing attempts - Add descriptive comment explaining the field purpose This is a follow-up to PR #82, implementing improvements suggested by GitHub Copilot review. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题：打开大部分节点时候空白，出现 Unknown Error(-1)
主题总数使用千分位，直接转换int会报错，
e.g.
主题总数 137,647
Caused by: java.lang.NumberFormatException: For input string: "137,647"
at java.lang.Integer.parseInt(Integer.java:781)
at java.lang.Integer.valueOf(Integer.java:1108)
at me.ghui.fruit.bind.PickAdapters.parseElement(PickAdapters.java:103)
at me.ghui.fruit.bind.PickAdapters.access$000(PickAdapters.java:17)
at me.ghui.fruit.bind.PickAdapters$2.read(PickAdapters.java:33)
at me.ghui.fruit.bind.PickAdapters$2.read(PickAdapters.java:30)
at me.ghui.fruit.bind.ReflectivePickAdapterFactory$1.read(ReflectivePickAdapterFactory.java:111)
at me.ghui.fruit.bind.ReflectivePickAdapterFactory$Adapter.read(ReflectivePickAdapterFactory.java:64)
at me.ghui.fruit.Fruit.fromHtml(Fruit.java:61)
at me.ghui.fruit.Fruit.fromHtml(Fruit.java:49)
at me.ghui.fruit.converter.retrofit.FruitResponseBodyConverter.convert(FruitResponseBodyConverter.java:28)
at me.ghui.fruit.converter.retrofit.FruitResponseBodyConverter.convert(FruitResponseBodyConverter.java:15)
at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:246)
at retrofit2.OkHttpCall.execute(OkHttpCall.java:207)
at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(CallExecuteObservable.java:46)
at io.reactivex.Observable.subscribe(Observable.java:12284)
at retrofit2.adapter.rxjava2.BodyObservable.subscribeActual(BodyObservable.java:35)
at io.reactivex.Observable.subscribe(Observable.java:12284)
at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:608)
at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
at java.lang.Thread.run(Thread.java:1119)