Skip to content

Commit 44c830c

Browse files
graycreateclaude
andcommitted
fix: address Copilot review comments for splash screen
- Remove hardcoded RGB color values from storyboard resources section - Use named color references only (SplashBackground, SplashLogoColor) - Update image resource dimensions to match display size (100x100) - Simplify image asset configuration (single universal image) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 5d25617 commit 44c830c

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

V2er/Assets.xcassets/SplashLogo.imageset/Contents.json

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,7 @@
22
"images" : [
33
{
44
"filename" : "splash_logo.png",
5-
"idiom" : "universal",
6-
"scale" : "1x"
7-
},
8-
{
9-
"idiom" : "universal",
10-
"scale" : "2x"
11-
},
12-
{
13-
"idiom" : "universal",
14-
"scale" : "3x"
5+
"idiom" : "universal"
156
}
167
],
178
"info" : {

V2er/LaunchScreen.storyboard

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,8 @@
4040
</scene>
4141
</scenes>
4242
<resources>
43-
<image name="SplashLogo" width="1024" height="1024"/>
44-
<namedColor name="SplashBackground">
45-
<color red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
46-
</namedColor>
47-
<namedColor name="SplashLogoColor">
48-
<color red="0.066999999999999993" green="0.070999999999999994" blue="0.078" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
49-
</namedColor>
43+
<image name="SplashLogo" width="100" height="100"/>
44+
<namedColor name="SplashBackground"/>
45+
<namedColor name="SplashLogoColor"/>
5046
</resources>
5147
</document>

0 commit comments

Comments
 (0)