fix: address PR review comments

graycreate · claude · graycreate · commit b50e116e4291 · 2025-09-13T22:57:23.000+08:00
- Extract hard-coded CSS colors into constants in Webview.swift - Fix text color contrast issue in TabBar badge (use white on red background) - Remove mock data implementation that was auto-reverted 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/V2er/View/Widget/RichTextView/Webview.swift b/V2er/View/Widget/RichTextView/Webview.swift
@@ -105,40 +105,46 @@ struct Webview : UIViewRepresentable {
         
     }
     
+    private let lightTextColor = "#1C1C1E"
+    private let darkTextColor = "#F2F2F7"
+
     func css(colorScheme: colorScheme) -> String {
+        let imgStyle = "img{max-height: 100%; min-height: 100%; height:auto; max-width: 100%; width:auto;margin-bottom:5px; border-radius: \(imageRadius)px;}"
+        let iframeStyle = "iframe{width:100%; height:250px;}"
+        let textStyleBase = "h1, h2, h3, h4, h5, h6, p, dl, ol, ul, pre, blockquote {text-align:left|right|center; line-height: \(lineHeight)%; font-family: '\(fontName(fontType: self.fontType))'; color: "
+        let importantSuffix = colorImportant == false ? "" : "!important"
+
         switch colorScheme {
         case .light:
             return """
             <style type='text/css'>
-                img{max-height: 100%; min-height: 100%; height:auto; max-width: 100%; width:auto;margin-bottom:5px; border-radius: \(imageRadius)px;}
-            h1, h2, h3, h4, h5, h6, p, dl, ol, ul, pre, blockquote {text-align:left|right|center; line-height: \(lineHeight)%; font-family: '\(fontName(fontType: self.fontType))'; color: #1C1C1E \(colorImportant == false ? "" : "!important"); }
-                iframe{width:100%; height:250px;}
-            
+                \(imgStyle)
+                \(textStyleBase)\(lightTextColor) \(importantSuffix); }
+                \(iframeStyle)
             </style>
             <BODY>
             """
-        case .dark :
+        case .dark:
             return """
             <style type='text/css'>
-                img{max-height: 100%; min-height: 100%; height:auto; max-width: 100%; width:auto;margin-bottom:5px; border-radius: \(imageRadius)px;}
-            h1, h2, h3, h4, h5, h6, p, dl, ol, ul, pre, blockquote {text-align:left|right|center; line-height: \(lineHeight)%; font-family: '\(fontName(fontType: self.fontType))'; color: #F2F2F7 \(colorImportant == false ? "" : "!important"); }
-                iframe{width:100%; height:250px;}
-            
+                \(imgStyle)
+                \(textStyleBase)\(darkTextColor) \(importantSuffix); }
+                \(iframeStyle)
             </style>
             <BODY>
             """
         case .automatic:
             return """
             <style type='text/css'>
             @media (prefers-color-scheme: light) {
-                img{max-height: 100%; min-height: 100%; height:auto; max-width: 100%; width:auto;margin-bottom:5px; border-radius: \(imageRadius)px;}
-            h1, h2, h3, h4, h5, h6, p, dl, ol, ul, pre, blockquote {text-align:left|right|center; line-height: \(lineHeight)%; font-family: '\(fontName(fontType: self.fontType))'; color: #1C1C1E \(colorImportant == false ? "" : "!important"); }
-                iframe{width:100%; height:250px;}
+                \(imgStyle)
+                \(textStyleBase)\(lightTextColor) \(importantSuffix); }
+                \(iframeStyle)
             }
             @media (prefers-color-scheme: dark) {
-                img{max-height: 100%; min-height: 100%; height:auto; max-width: 100%; width:auto;margin-bottom:5px; border-radius: \(imageRadius)px;}
-            h1, h2, h3, h4, h5, h6, p, dl, ol, ul, pre, blockquote {text-align:left|right|center; line-height: \(lineHeight)%; font-family: '\(fontName(fontType: self.fontType))'; color: #F2F2F7 \(colorImportant == false ? "" : "!important"); }
-                iframe{width:100%; height:250px;}
+                \(imgStyle)
+                \(textStyleBase)\(darkTextColor) \(importantSuffix); }
+                \(iframeStyle)
             }
             </style>
             <BODY>
diff --git a/V2er/View/Widget/TabBar.swift b/V2er/View/Widget/TabBar.swift
@@ -76,7 +76,7 @@ struct TabBar: View {
             VStack {
                 Text(num.string)
                     .font(.system(size: 10))
-                    .foregroundColor(Color.itemBackground)
+                    .foregroundColor(.white)
                     .padding(4)
                     .background {
                         Circle()
