clang-format: readability-container-size-empty

Author: v4hn

.clang-tidy

@@ -5,6 +5,7 @@ Checks:          '-*,
                   modernize-use-using,
                   modernize-loop-convert,
                   readability-named-parameter,
+                  readability-container-size-empty,
                   '
 HeaderFilterRegex: '.*/moveit/task_constructor/.*\.h'
 AnalyzeTemporaryDtors: false

capabilities/src/execute_task_solution_capability.cpp

@@ -151,7 +151,7 @@ bool ExecuteTaskSolutionCapability::constructMotionPlan(const moveit_task_constr
 			std::vector<std::string> joint_names(sub_traj.trajectory.joint_trajectory.joint_names);
 			joint_names.insert(joint_names.end(), sub_traj.trajectory.multi_dof_joint_trajectory.joint_names.begin(),
 			                   sub_traj.trajectory.multi_dof_joint_trajectory.joint_names.end());
-			if (joint_names.size()) {
+			if (!joint_names.empty()) {
 				group = findJointModelGroup(*model, joint_names);
 				if (!group) {
 					ROS_ERROR_STREAM_NAMED("ExecuteTaskSolution", "Could not find JointModelGroup that actuates {"

core/src/stages/fixed_cartesian_poses.cpp

@@ -70,7 +70,7 @@ void FixedCartesianPoses::onNewSolution(const SolutionBase& s) {
 }
 
 bool FixedCartesianPoses::canCompute() const {
-	return upstream_solutions_.size() > 0;
+	return !upstream_solutions_.empty();
 }
 
 void FixedCartesianPoses::compute() {

core/src/stages/generate_pose.cpp

@@ -60,7 +60,7 @@ void GeneratePose::onNewSolution(const SolutionBase& s) {
 }
 
 bool GeneratePose::canCompute() const {
-	return upstream_solutions_.size() > 0;
+	return !upstream_solutions_.empty();
 }
 
 void GeneratePose::compute() {

visualization/visualization_tools/src/display_solution.cpp

@@ -118,7 +118,7 @@ void DisplaySolution::setFromMessage(const planning_scene::PlanningScenePtr& sta
 		// create new reference scene for next iteration
 		ref_scene = ref_scene->diff();
 
-		if (sub.info.markers.size())
+		if (!sub.info.markers.empty())
 			data_[i].markers_.reset(new MarkerVisualization(sub.info.markers, *ref_scene));
 		else
 			data_[i].markers_.reset();