Skip to content

Commit 6fd6086

Browse files
committed
fix for remove column macros
1 parent 5582d1b commit 6fd6086

File tree

5 files changed

+3
-27
lines changed

5 files changed

+3
-27
lines changed

modules/graph/grin/predefine.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -632,18 +632,6 @@ typedef enum {
632632
* @brief Assume full property values of an edge are split among master and mirror edges.
633633
*/
634634
#define GRIN_ASSUME_SPLIT_MASTER_MIRROR_PARTITION_FOR_EDGE_PROPERTY
635-
636-
/** @ingroup PropetyAssumptionMacros
637-
* @brief The storage uses column store for vertex properties.
638-
* This enables efficient property selections for vertices.
639-
*/
640-
#define GRIN_ASSUME_COLUMN_STORE_FOR_VERTEX_PROPERTY
641-
642-
/** @ingroup PropetyAssumptionMacros
643-
* @brief The storage uses column store for edge properties.
644-
* This enables efficient property selections for edges.
645-
*/
646-
#define GRIN_ASSUME_COLUMN_STORE_FOR_EDGE_PROPERTY
647635
///@}
648636

649637
#ifndef GRIN_DOXYGEN_SKIP
@@ -673,8 +661,6 @@ typedef enum {
673661
#undef GRIN_ASSUME_MASTER_ONLY_PARTITION_FOR_EDGE_PROPERTY
674662
#undef GRIN_ASSUME_REPLICATE_MASTER_MIRROR_PARTITION_FOR_EDGE_PROPERTY
675663
#undef GRIN_ASSUME_SPLIT_MASTER_MIRROR_PARTITION_FOR_EDGE_PROPERTY
676-
#undef GRIN_ASSUME_COLUMN_STORE_FOR_VERTEX_PROPERTY
677-
#undef GRIN_ASSUME_COLUMN_STORE_FOR_EDGE_PROPERTY
678664
// GRIN_END
679665

680666
// GRIN_STORAGE_ENABLE
@@ -693,8 +679,6 @@ typedef enum {
693679
#define GRIN_TRAIT_NATURAL_ID_FOR_EDGE_PROPERTY
694680
#define GRIN_TRAIT_SELECT_TYPE_FOR_VERTEX_LIST
695681
#define GRIN_TRAIT_SELECT_EDGE_TYPE_FOR_ADJACENT_LIST
696-
#define GRIN_ASSUME_COLUMN_STORE_FOR_VERTEX_PROPERTY
697-
#define GRIN_ASSUME_COLUMN_STORE_FOR_EDGE_PROPERTY
698682
// GRIN_END
699683

700684
// GRIN_FEATURE_DEPENDENCY

modules/graph/grin/src/property/property.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ extern "C" {
1515
#include "graph/grin/include/property/property.h"
1616
}
1717

18+
void grin_destroy_string_value(GRIN_GRAPH g, const char* value) {}
19+
1820
#ifdef GRIN_WITH_VERTEX_PROPERTY_NAME
1921
const char* grin_get_vertex_property_name(GRIN_GRAPH g, GRIN_VERTEX_TYPE vtype, GRIN_VERTEX_PROPERTY vp) {
2022
auto _cache = static_cast<GRIN_GRAPH_T*>(g)->cache;

modules/graph/grin/src/property/row.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ extern "C" {
1616
#include "graph/grin/include/common/error.h"
1717
}
1818

19-
void grin_destroy_string_value(GRIN_GRAPH g, const char* value) {}
20-
2119
#ifdef GRIN_ENABLE_ROW
2220
void grin_destroy_row(GRIN_GRAPH g, GRIN_ROW r) {
2321
auto _r = static_cast<GRIN_ROW_T*>(r);

modules/graph/grin/src/proto/message.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -264,14 +264,6 @@ const char* grin_get_static_storage_feature_msg() {
264264
efeature->set_grin_trait_natural_id_for_edge_property(true);
265265
#endif
266266

267-
#ifdef GRIN_ASSUME_COLUMN_STORE_FOR_VERTEX_PROPERTY
268-
feature->set_grin_assume_column_store_for_vertex_property(true);
269-
#endif
270-
271-
#ifdef GRIN_ASSUME_COLUMN_STORE_FOR_EDGE_PROPERTY
272-
feature->set_grin_assume_column_store_for_edge_property(true);
273-
#endif
274-
275267
#ifdef GRIN_TRAIT_SELECT_TYPE_FOR_VERTEX_LIST
276268
feature->set_grin_trait_select_type_for_vertex_list(true);
277269
#endif

0 commit comments

Comments
 (0)