Skip to content

Commit cd8227f

Browse files
committed
Delete CppGC teardown code
V8 is doing the teardown now, so there is no need for node to do it.
1 parent c14d3ba commit cd8227f

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

src/env.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -602,14 +602,6 @@ IsolateData::IsolateData(Isolate* isolate,
602602
}
603603
}
604604

605-
IsolateData::~IsolateData() {
606-
if (cpp_heap_ != nullptr) {
607-
// The CppHeap must be detached before being terminated.
608-
isolate_->DetachCppHeap();
609-
cpp_heap_->Terminate();
610-
}
611-
}
612-
613605
// Deprecated API, embedders should use v8::Object::Wrap() directly instead.
614606
void SetCppgcReference(Isolate* isolate,
615607
Local<Object> object,

src/env.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ class NODE_EXTERN_PRIVATE IsolateData : public MemoryRetainer {
155155
ArrayBufferAllocator* node_allocator = nullptr,
156156
const EmbedderSnapshotData* embedder_snapshot_data = nullptr,
157157
std::shared_ptr<PerIsolateOptions> options = nullptr);
158-
~IsolateData();
159158

160159
SET_MEMORY_INFO_NAME(IsolateData)
161160
SET_SELF_SIZE(IsolateData)
@@ -258,7 +257,6 @@ class NODE_EXTERN_PRIVATE IsolateData : public MemoryRetainer {
258257
const SnapshotData* snapshot_data_;
259258
std::optional<SnapshotConfig> snapshot_config_;
260259

261-
std::unique_ptr<v8::CppHeap> cpp_heap_;
262260
std::shared_ptr<PerIsolateOptions> options_;
263261
worker::Worker* worker_context_ = nullptr;
264262
PerIsolateWrapperData* wrapper_data_;

0 commit comments

Comments
 (0)