Skip to content

Commit d89beb8

Browse files
committed
Fix calls to Object::wrap
1 parent 1321446 commit d89beb8

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/env.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -610,7 +610,7 @@ IsolateData::~IsolateData() {}
610610
// Deprecated API, embedders should use v8::Object::Wrap() directly instead.
611611
void SetCppgcReference(Isolate* isolate,
612612
Local<Object> object,
613-
void* wrappable) {
613+
v8::Object::Wrappable* wrappable) {
614614
v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
615615
isolate, object, wrappable);
616616
}

src/node.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1542,7 +1542,7 @@ void RegisterSignalHandler(int signal,
15421542
NODE_DEPRECATED("Use v8::Object::Wrap()",
15431543
NODE_EXTERN void SetCppgcReference(v8::Isolate* isolate,
15441544
v8::Local<v8::Object> object,
1545-
void* wrappable));
1545+
v8::Object::Wrappable* wrappable));
15461546

15471547
} // namespace node
15481548

test/addons/cppgc-object/binding.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <v8.h>
99
#include <algorithm>
1010

11-
class CppGCed : public cppgc::GarbageCollected<CppGCed> {
11+
class CppGCed : public v8::Object::Wrappable {
1212
public:
1313
static uint16_t states[2];
1414
static constexpr int kDestructCount = 0;

test/cctest/test_cppgc.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// This tests that Node.js can work with an existing CppHeap.
1111

1212
// Mimic a class that does not know about Node.js.
13-
class CppGCed : public cppgc::GarbageCollected<CppGCed> {
13+
class CppGCed : public v8::Object::Wrappable {
1414
public:
1515
static int kConstructCount;
1616
static int kDestructCount;

0 commit comments

Comments
 (0)