added more tests, added testing initialization

Author: mtboren

testing/vNugglets.Utility.TestingInit.ps1

@@ -0,0 +1,16 @@
+## initialization code for use by multiple *.Tests.ps1 files for testing vNugglets.Utility PowerShell module
+
+$strNameOfModuleToTest = "vNugglets.Utility"
+## if module not already loaded, try to load it (assumes that module is in PSModulePath)
+if (-not ($oModuleInfo = Get-Module $strNameOfModuleToTest)) {
+	$oModuleInfo = Import-Module $strNameOfModuleToTest -PassThru
+	if (-not ($oModuleInfo -is [System.Management.Automation.PSModuleInfo])) {Throw "Could not load module '$strNameOfModuleToTest' -- is it available in the PSModulePath? You can manually load the module and start tests again"}
+} ## end if
+Write-Verbose -Verbose ("Starting testing of module '{0}' (version '{1}' from '{2}')" -f $oModuleInfo.Name, $oModuleInfo.Version, $oModuleInfo.Path)
+
+## ensure that this session is connected to at least one vCenter server (prompt to do so if not already connected)
+$oSomeVCConnection = if (-not (($global:DefaultVIServers | Measure-Object).Count -gt 0)) {
+	$hshParamForConnectVIServer = @{Server = $(Read-Host -Prompt "vCenter server name to which to connect for testing")}
+	ConnVIServer @hshParamForConnectVIServer
+} ## end if
+else {$global:DefaultVIServers[0]}

testing/vNugglets.Utility.Tests_Unit.ps1

@@ -1,11 +1,11 @@
 <#	.Description
-	Pester tests for vNugglets.Utility PowerShell module.  Expects that:
+	Pester tests for vNugglets.Utility PowerShell module.  Will expect that (once fully written):
 	0) vNugglets.Utility module is already loaded (but, will try to load it if not)
 	1) a connection to at least one vCenter is in place (but, will prompt for vCenter to which to connect if not)
 #>
 
 ## initialize things, preparing for tests
-# . $PSScriptRoot\vNugglets.Utility.TestingInit.ps1
+. $PSScriptRoot\vNugglets.Utility.TestingInit.ps1
 
 Write-Verbose -Verbose "tests not yet fully written"
 
@@ -21,24 +21,59 @@ Get-VNVMByVirtualPortGroup
 Get-VNVMDiskAndRDM
 Get-VNVMEVCInfo
 Get-VNVMHostBrokenUplink
-Get-VNVMHostFirmwareInfo
-Get-VNVMHostLogicalVolumeInfo
-Get-VNVMHostNICFirmwareAndDriverInfo
 Invoke-VNEvacuateDatastore
 Move-VNTemplateFromVMHost
 Update-VNTitleBarForPowerCLI
 #>
 
-Describe -Tags "Get" -Name "Get-VNVMHostHBAWWN" {
-	It "Gets VMHost HBA WWN information" {
-		## the NoteProperties that the return objects should have
-		$arrExpectedReturnObjNotePropertyNames = Write-Output DeviceName HBANodeWWN HBAPortWWN HBAStatus VMHostName
-		$arrReturnObj = Get-VMHost -State Connected | Select-Object -First 1 | Get-VNVMHostHBAWWN
-		$arrReturnTypes = $arrReturnObj | Get-Member | Select-Object -Unique -ExpandProperty TypeName
-		$bGetsOnlyPSCustomObjectType = $arrReturnTypes -eq "System.Management.Automation.PSCustomObject"
-		## does the array of names of NoteProperties in the set of return objects have only the values expected for return objects? (does the comparison of the arrays return no difference objects?)
-		$bHasExpectedNoteProperties = $null -eq (Compare-Object -ReferenceObject $arrExpectedReturnObjNotePropertyNames -DifferenceObject ($arrReturnObj | Get-Member -MemberType NoteProperty).Name)
-		$bGetsOnlyPSCustomObjectType | Should Be $true
-		$bHasExpectedNoteProperties | Should Be $true
-	} ## end it
-} ## end describe
+$oTestVMHost = Get-VMHost -State Connected | Select-Object -First 1
+
+## array of objects, each with information about what and how to test for the given cmdlet; used to create, for each cmdlet, the actual tests below
+$arrInfoOnCmdletsToTest = @(
+	New-Object -Type PSObject -Property @{
+		CmdletName = "Get-VNVMHostFirmwareInfo"
+		TestDescription = "Gets VMHost physical server's firmware information (HP-focused)"
+		ExpectedReturnTypename = "System.Management.Automation.PSCustomObject"
+		ExpectedReturnObjNotePropertyNames = Write-Output HPSmartArray iLOFirmware Model SystemBIOS VMHostName
+		TestScriptblock = {$oTestVMHost | Get-VNVMHostFirmwareInfo}
+	}
+	New-Object -Type PSObject -Property @{
+		CmdletName = "Get-VNVMHostHBAWWN"
+		TestDescription = "Gets VMHost HBA WWN information"
+		ExpectedReturnTypename = "System.Management.Automation.PSCustomObject"
+		ExpectedReturnObjNotePropertyNames = Write-Output DeviceName HBANodeWWN HBAPortWWN HBAStatus VMHostName
+		TestScriptblock = {$oTestVMHost | Get-VNVMHostHBAWWN}
+	}
+	New-Object -Type PSObject -Property @{
+		CmdletName = "Get-VNVMHostLogicalVolumeInfo"
+		TestDescription = "Gets VMHost's logical volume information"
+		ExpectedReturnTypename = "System.Management.Automation.PSCustomObject"
+		ExpectedReturnObjNotePropertyNames = Write-Output LogicalVolume VMHostName
+		TestScriptblock = {$oTestVMHost | Get-VNVMHostLogicalVolumeInfo}
+	}
+	New-Object -Type PSObject -Property @{
+		CmdletName = "Get-VNVMHostNICFirmwareAndDriverInfo"
+		TestDescription = "Gets VMHost's NIC drive and firmware information"
+		ExpectedReturnTypename = "System.Management.Automation.PSCustomObject"
+		ExpectedReturnObjNotePropertyNames = Write-Output NicDriverVersion NicFirmwareVersion VMHostName
+		TestScriptblock = {$oTestVMHost | Get-VNVMHostNICFirmwareAndDriverInfo}
+	}
+)
+
+## perform the actual tests for standard Get- types of cmdlets
+$arrInfoOnCmdletsToTest | Foreach-Object {
+	$oInfoForThisCmdletTest = $_
+	Describe -Tags "Get" -Name $oInfoForThisCmdletTest.CmdletName {
+		It $oInfoForThisCmdletTest.TestDescription {
+			## the NoteProperties that the return objects should have
+			$arrExpectedReturnObjNotePropertyNames = $oInfoForThisCmdletTest.ExpectedReturnObjNotePropertyNames
+			$arrReturnObj = & $oInfoForThisCmdletTest.TestScriptblock
+			$arrReturnTypes = $arrReturnObj | Get-Member | Select-Object -Unique -ExpandProperty TypeName
+			$bGetsOnlyExpectedObjectType = $arrReturnTypes -eq $oInfoForThisCmdletTest.ExpectedReturnTypename
+			## does the array of names of NoteProperties in the set of return objects have only the values expected for return objects? (does the comparison of the arrays return no difference objects?)
+			$bHasExpectedNoteProperties = $null -eq (Compare-Object -ReferenceObject $arrExpectedReturnObjNotePropertyNames -DifferenceObject ($arrReturnObj | Get-Member -MemberType NoteProperty).Name)
+			$bGetsOnlyExpectedObjectType | Should Be $true
+			$bHasExpectedNoteProperties | Should Be $true
+		} ## end it
+	} ## end describe
+} ## end foreach-object

vNugglets.Utility/vNuggletsUtilityMod_functions.ps1

@@ -799,7 +799,7 @@ function Connect-VNVIServer {
     Function to use for connecting to VIServers instead of the default "Connect-VIServer" cmdlet -- includes call to function to update PowerShell window's title bar with the VIServer(s) to which the current session has connections
 
     .Example
-    Connect-VNVIServer -Credential $myCred -VIServer myVC0.dom.com, myVC1.dom.com
+    Connect-VNVIServer -Credential $myCred -Server myVC0.dom.com, myVC1.dom.com
     Connects to the given vCenters using the given credentials, and updates the PowerShell window's title bar accordingly
 
     .Link
@@ -812,15 +812,15 @@ function Connect-VNVIServer {
 #>
     param(
         ## Name of VI server to which to connect
-        [parameter(Mandatory=$true, Position=0)][string[]]$VIServer,
+        [parameter(Mandatory=$true, Position=0)][string[]]$Server,
 
         ## Credential to use for connection
         [parameter(Position=1)][ValidateNotNullOrEmpty()][System.Management.Automation.PSCredential]$Credential
     ) ## end param
 
     process {
         ## check that given target VIServers are responsive to ping requests (assumes that ICMP echo traffic is allowed from the target machine)
-        $arrVIServersToWhichToConnect = $VIServer | Foreach-Object {
+        $arrVIServersToWhichToConnect = $Server | Foreach-Object {
             $strVIServerToWhichToConnect = $_
             if (-not (Test-Connection -Quiet -Count 2 $strVIServerToWhichToConnect)) {Write-Warning "server at '$strVIServerToWhichToConnect' not reachable; not trying to connect"}
             else {$strVIServerToWhichToConnect}
@@ -854,11 +854,11 @@ function Disconnect-VNVIServer {
 #>
     param (
         ## Name(s) of the VIServers from which to disconnect.  Accepts wildcards.  Disconnects from all VIServer if none specified here.
-        [string[]]$VIServer = "*"
+        [string[]]$Server = "*"
     ) ## end param
 
     process {
-        Disconnect-VIServer -Server $VIServer -Confirm:$false
+        Disconnect-VIServer -Server $Server -Confirm:$false
         ## update the PowerShell WindowTitle
         Update-VNTitleBarForPowerCLI
     } ## end process