refactor: upgrade to v25 #16
Open
+239
−2,176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
force-pushed
the
refactor/v25-upgrade
branch
from
c6f475a to
0a6403f
Compare
web-padawan
reviewed
Oct 30, 2025
| --anchor-nav-inner-padding: 0; | ||
| --anchor-nav-tabs-background: #fff; | ||
| --anchor-nav-tabs-stuck-box-shadow: 0 4px 5px -6px rgba(0, 0, 0, 0.4); | ||
| /* |
There was a problem hiding this comment.
nit: some incorrect indentation in the comment.
web-padawan
reviewed
Oct 30, 2025
Comment on lines
-263
to
-265
| this.$.slot.addEventListener('slotchange', () => this._onSlotChange()); | ||
| this.$.tabsSlot.addEventListener('slotchange', e => this._onTabsSlotChange(e)); | ||
| this.$.headerSlot.addEventListener('slotchange', () => this._onHeaderSlotChange()); |
There was a problem hiding this comment.
I wonder if we should use PolylitMixin like some other add-ons do? It would allow to reduce such changes.
web-padawan
reviewed
Oct 30, 2025
Comment on lines
+598
to
+599
| const scrollElement = tabs.shadowRoot && tabs.shadowRoot.querySelector('[part="tabs"]'); | ||
| const backButton = tabs.shadowRoot && tabs.shadowRoot.querySelector('[part="back-button"]'); |
There was a problem hiding this comment.
nit: could use tabs.shadowRoot?.querySelector('[part="tabs"]'); instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the component to work with v25:
__isCustomTabmarker propertyThemeDetectionMixin.ThemableMixin(shadow root style injection). It's not needed by the component itself, and users should not use it as it's going to be dropped in a future version.