Skip to content

Commit c389b58

Browse files
committed
fix: solve overlapping issues inside form layout
Fix unwanted overlapping when the form is too narrow.
1 parent 73a76b5 commit c389b58

File tree

3 files changed

+24
-2
lines changed

3 files changed

+24
-2
lines changed

demo/index.html

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,16 @@
4141
openDateRangePickerButton.addEventListener('click', function(e) {
4242
dateRangePickerWithoutTextFields.openOnPosition(event.clientX,event.clientY);
4343
});
44+
45+
var formLayout = document.querySelector('#formLayout');
46+
47+
formLayout.responsiveSteps = [
48+
{minWidth: 0, columns: 1, labelsPosition: 'top'},
49+
{minWidth: '10em', columns: 1},
50+
{minWidth: '20em', columns: 2},
51+
{minWidth: '30em', columns: 3}
52+
];
53+
4454
});
4555
</script>
4656
</head>
@@ -87,8 +97,10 @@ <h3>Clear button</h3>
8797
<h3>Inside Form Layout</h3>
8898
<demo-snippet>
8999
<template preserve-content>
90-
<vaadin-form-layout>
100+
<vaadin-form-layout id="formLayout">
91101
<vaadin-text-field label="First Name" value="Jane"></vaadin-text-field>
102+
<vaadin-text-field label="Last Name" value="Smith"></vaadin-text-field>
103+
<vaadin-text-field label="Address" value="A place"></vaadin-text-field>
92104
<vcf-date-range-picker clear-button-visible label="Super long super long super long super long super long super long super long super long super label" value="1990-01-28" error-message="Super long super long super long super long super long super long super long super long super error "></vcf-date-range-picker>
93105
<vaadin-text-field label="Email" value="[email protected]"></vaadin-text-field>
94106
<vaadin-date-picker label="Birthday" value="1993-06-23"></vaadin-date-picker>

src/vcf-date-range-picker.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,15 @@ import { afterNextRender } from '@polymer/polymer/lib/utils/render-status.js';
120120
[part="end-text-field"] {
121121
align-self: baseline;
122122
flex-grow: 1;
123-
--vaadin-text-field-default-width: 16ch;
124123
overflow: hidden;
124+
--vaadin-text-field-default-width: 16ch;
125+
}
126+
[focus-ring][part="end-text-field"] {
127+
padding-left: 2px;
128+
padding-right: 2px;
129+
}
130+
[focus-ring][part="end-text-field"] [part="toggle-button"] {
131+
margin-right: -2px;
125132
}
126133
[part="dash"][hidden] {
127134
display: none;

theme/lumo/vcf-date-range-picker-text-field-styles.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ registerStyles(
4848
:host([id="startInput"]) [part="input-field"] {
4949
padding-right:0px;
5050
}
51+
:host([id="endInput"][focus-ring]) [part="value"] {
52+
margin-left:-2px;
53+
}
5154
:host([id="startInput"]) [part="value"] {
5255
padding-right:0px;
5356
}

0 commit comments

Comments
 (0)