fix: provide default MenuAccessControl instance (#460)

A MenuAccessControl instance is required when operating with MenuConfiguration.
This change provides a default implementation if the user project does not
define a specialized bean.

Co-authored-by: Tomi Virtanen <tltv@vaadin.com>

Author: mcollovati

vaadin-cdi/src/main/java/com/vaadin/cdi/AbstractCdiInstantiator.java

@@ -27,6 +27,7 @@
 import com.vaadin.flow.di.Instantiator;
 import com.vaadin.flow.i18n.I18NProvider;
 import com.vaadin.flow.server.VaadinServiceInitListener;
+import com.vaadin.flow.server.auth.MenuAccessControl;
 
 abstract public class AbstractCdiInstantiator implements Instantiator {
 
@@ -78,6 +79,13 @@ public I18NProvider getI18NProvider() {
         return lookup.lookupOrElseGet(getDelegate()::getI18NProvider);
     }
 
+    @Override
+    public MenuAccessControl getMenuAccessControl() {
+        final BeanLookup<MenuAccessControl> lookup = new BeanLookup<>(
+                getBeanManager(), MenuAccessControl.class, BeanLookup.SERVICE);
+        return lookup.lookupOrElseGet(getDelegate()::getMenuAccessControl);
+    }
+
     private static Logger getLogger() {
         return LoggerFactory.getLogger(CdiInstantiator.class);
     }

vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorDefaultsTest.java

@@ -0,0 +1,62 @@
+package com.vaadin.cdi;
+
+import jakarta.enterprise.inject.spi.BeanManager;
+import jakarta.inject.Inject;
+
+import org.jboss.weld.junit5.EnableWeld;
+import org.jboss.weld.junit5.WeldInitiator;
+import org.jboss.weld.junit5.WeldSetup;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import com.vaadin.cdi.annotation.VaadinServiceEnabled;
+import com.vaadin.cdi.annotation.VaadinServiceScoped;
+import com.vaadin.cdi.context.ServiceUnderTestContext;
+import com.vaadin.cdi.context.VaadinServiceScopedContext;
+import com.vaadin.flow.di.Instantiator;
+import com.vaadin.flow.server.VaadinService;
+import com.vaadin.flow.server.auth.DefaultMenuAccessControl;
+import com.vaadin.flow.server.auth.MenuAccessControl;
+
+@EnableWeld
+public class CdiInstantiatorDefaultsTest {
+
+    @WeldSetup
+    public WeldInitiator weld = WeldInitiator.from(
+            CdiInstantiatorFactory.class, CdiInstantiator.class,
+            VaadinServiceScopedContext.ContextualStorageManager.class
+    ).activate(VaadinServiceScoped.class).build();
+
+    @Inject
+    private BeanManager beanManager;
+
+    @Inject
+    @VaadinServiceEnabled
+    private CdiInstantiatorFactory instantiatorFactory;
+
+    private Instantiator instantiator;
+
+    private ServiceUnderTestContext serviceUnderTestContext;
+
+    @BeforeEach
+    public void setUp() {
+        serviceUnderTestContext = new ServiceUnderTestContext(beanManager);
+        serviceUnderTestContext.activate();
+        instantiator = instantiatorFactory.createInstantitor(VaadinService.getCurrent());
+    }
+
+    @AfterEach
+    public void tearDown() {
+        serviceUnderTestContext.tearDownAll();
+    }
+
+    @Test
+    public void getMenuAccessControl_beanNotProvided_instanceReturned() {
+        MenuAccessControl menuAccessControl = instantiator
+                .getMenuAccessControl();
+        Assertions.assertNotNull(menuAccessControl);
+        Assertions.assertInstanceOf(DefaultMenuAccessControl.class, menuAccessControl);
+    }
+}

vaadin-cdi/src/test/java/com/vaadin/cdi/CdiInstantiatorTest.java

@@ -38,6 +38,8 @@
 import com.vaadin.flow.internal.UsageStatistics;
 import com.vaadin.flow.server.ServiceInitEvent;
 import com.vaadin.flow.server.VaadinService;
+import com.vaadin.flow.server.auth.MenuAccessControl;
+
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.BeforeEach;
@@ -111,6 +113,21 @@ public String getTranslation(String key, Locale locale,
 
     }
 
+    @VaadinServiceEnabled
+    public static class TestMenuAccessControl implements MenuAccessControl {
+
+        @Override
+        public void setPopulateClientSideMenu(
+                PopulateClientMenu populateClientSideMenu) {
+
+        }
+
+        @Override
+        public PopulateClientMenu getPopulateClientSideMenu() {
+            return null;
+        }
+    }
+
     @Singleton
     public static class ServiceInitObserver {
 
@@ -162,6 +179,14 @@ public void getI18NProvider_beanEnabled_instanceReturned() {
         Assertions.assertTrue((i18NProvider instanceof I18NTestProvider));
     }
 
+    @Test
+    public void getMenuAccessControl_beanEnabled_instanceReturned() {
+        MenuAccessControl menuAccessControl = instantiator
+                .getMenuAccessControl();
+        Assertions.assertNotNull(menuAccessControl);
+        Assertions.assertInstanceOf(TestMenuAccessControl.class, menuAccessControl);
+    }
+
     @Test
     public void getServiceInitListeners_javaSPIListenerExists_containsJavaSPIListener() {
         Assertions.assertTrue(instantiator.getServiceInitListeners().anyMatch(