refactor: override HasStyle implementation in Notification (#4591)

Author: web-padawan

vaadin-notification-flow-parent/vaadin-notification-flow/src/main/java/com/vaadin/flow/component/notification/Notification.java

@@ -37,6 +37,8 @@
 import com.vaadin.flow.component.dependency.JsModule;
 import com.vaadin.flow.component.dependency.NpmPackage;
 import com.vaadin.flow.component.shared.HasThemeVariant;
+import com.vaadin.flow.component.shared.internal.OverlayClassListProxy;
+import com.vaadin.flow.dom.ClassList;
 import com.vaadin.flow.dom.Element;
 import com.vaadin.flow.dom.ElementDetachListener;
 import com.vaadin.flow.dom.Style;
@@ -57,7 +59,6 @@
 @NpmPackage(value = "@vaadin/notification", version = "24.0.0-alpha12")
 @JsModule("@vaadin/notification/src/vaadin-notification.js")
 @JsModule("./flow-component-renderer.js")
-@JsModule("./notificationConnector.js")
 public class Notification extends Component implements HasComponents, HasStyle,
         HasThemeVariant<NotificationVariant> {
 
@@ -575,7 +576,6 @@ protected void onAttach(AttachEvent attachEvent) {
         super.onAttach(attachEvent);
         getElement().executeJs(
                 "Vaadin.FlowComponentHost.patchVirtualContainer(this)");
-        initConnector();
         configureRenderer();
         updateVirtualChildNodeIds();
     }
@@ -598,9 +598,25 @@ protected void onDetach(DetachEvent detachEvent) {
         });
     }
 
-    private void initConnector() {
-        getElement().executeJs(
-                "window.Vaadin.Flow.notificationConnector.initLazy(this)");
+    /**
+     * Sets the CSS class names of the notification overlay element. This method
+     * overwrites any previous set class names.
+     *
+     * @param className
+     *            a space-separated string of class names to set, or
+     *            <code>null</code> to remove all class names
+     */
+    @Override
+    public void setClassName(String className) {
+        getClassNames().clear();
+        if (className != null) {
+            addClassNames(className.split(" "));
+        }
+    }
+
+    @Override
+    public ClassList getClassNames() {
+        return new OverlayClassListProxy(this);
     }
 
     /**

vaadin-notification-flow-parent/vaadin-notification-flow/src/main/resources/META-INF/resources/frontend/notificationConnector.js

@@ -0,0 +1,134 @@
+/*
+ * Copyright 2000-2023 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.flow.component.notification;
+
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+import com.vaadin.flow.component.UI;
+import com.vaadin.flow.component.shared.internal.OverlayClassListProxy;
+import com.vaadin.flow.server.VaadinSession;
+
+public class NotificationHasStyleTest {
+
+    private UI ui = new UI();
+    private Notification notification;
+
+    @Before
+    public void setup() {
+        UI.setCurrent(ui);
+
+        VaadinSession session = Mockito.mock(VaadinSession.class);
+        Mockito.when(session.hasLock()).thenReturn(true);
+        ui.getInternals().setSession(session);
+
+        notification = new Notification();
+        ui.add(notification);
+    }
+
+    @After
+    public void tearDown() {
+        UI.setCurrent(null);
+    }
+
+    @Test
+    public void addClassName_notificationHasOverlayClass() {
+        notification.addClassName("foo");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), "foo");
+
+        notification.addClassName("bar");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"),
+                "foo bar");
+    }
+
+    @Test
+    public void removeClassName_notificationHasOverlayClass() {
+        notification.addClassName("foo");
+
+        notification.removeClassName("foo");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), null);
+    }
+
+    @Test
+    public void setClassNameString_notificationHasOverlayClass() {
+        notification.setClassName("foo");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), "foo");
+
+        notification.setClassName("bar");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), "bar");
+    }
+
+    @Test
+    public void setClassNameBoolean_notificationHasOverlayClass() {
+        notification.setClassName("foo", true);
+
+        notification.setClassName("foo", false);
+
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), null);
+    }
+
+    @Test
+    public void setClassNameMultiple_notificationHasOverlayClass() {
+        notification.setClassName("foo bar");
+        notification.getClassNames().set("foo", false);
+
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"), "bar");
+    }
+
+    @Test
+    public void addClassNames_notificationHasOverlayClass() {
+        notification.addClassNames("foo", "bar");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"),
+                "foo bar");
+
+        notification.addClassNames("baz", "qux");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"),
+                "foo bar baz qux");
+    }
+
+    @Test
+    public void removeClassNames_notificationHasOverlayClass() {
+        notification.addClassNames("foo", "bar", "baz", "qux");
+
+        notification.removeClassNames("foo", "bar");
+        Assert.assertEquals(
+                notification.getElement().getProperty("overlayClass"),
+                "baz qux");
+    }
+
+    @Test(expected = UnsupportedOperationException.class)
+    public void getStyle_unsupported() {
+        notification.getStyle();
+    }
+
+    @Test
+    public void getClassNames_usesProxy() {
+        Assert.assertTrue(
+                notification.getClassNames() instanceof OverlayClassListProxy);
+    }
+}