Skip to content

Commit 2cf0ae4

Browse files
vursenDiegoCardoso
andauthored
refactor: clean up FlowComponentRenderer leftovers (#7987)
Co-authored-by: Diego Cardoso <[email protected]>
1 parent 374dd14 commit 2cf0ae4

File tree

1 file changed

+0
-20
lines changed
  • vaadin-grid-flow-parent/vaadin-grid-flow/src/main/resources/META-INF/resources/frontend

1 file changed

+0
-20
lines changed

vaadin-grid-flow-parent/vaadin-grid-flow/src/main/resources/META-INF/resources/frontend/gridConnector.ts

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -258,26 +258,6 @@ window.Vaadin.Flow.gridConnector.initLazy = (grid) => {
258258
grid.__updateRow = function (row) {
259259
Grid.prototype.__updateRow.call(grid, row);
260260

261-
// There might be inactive component renderers on hidden rows that still refer to the
262-
// same component instance as one of the renderers on a visible row. Making the
263-
// inactive/hidden renderer attach the component might steal it from a visible/active one.
264-
if (!row.hidden) {
265-
// make sure that component renderers are updated
266-
Array.from(row.children).forEach((cell) => {
267-
Array.from(cell?._content?.__templateInstance?.children || []).forEach((content) => {
268-
if (content._attachRenderedComponentIfAble) {
269-
content._attachRenderedComponentIfAble();
270-
}
271-
// In hierarchy column of tree grid, the component renderer is inside its content,
272-
// this updates it renderer from innerContent
273-
Array.from(content?.children || []).forEach((innerContent) => {
274-
if (innerContent._attachRenderedComponentIfAble) {
275-
innerContent._attachRenderedComponentIfAble();
276-
}
277-
});
278-
});
279-
});
280-
}
281261
// since no row can be selected when selection mode is NONE
282262
// if selectionMode is set to NONE, remove aria-selected attribute from the row
283263
if (selectionMode === validSelectionModes[1]) {

0 commit comments

Comments
 (0)