Skip to content

Commit 2d06330

Browse files
authored
refactor!: remove deprecated remove and removeAll from ComboBox (#4599)
1 parent 689d42b commit 2d06330

File tree

1 file changed

+0
-38
lines changed
  • vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox

1 file changed

+0
-38
lines changed

vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import java.util.Objects;
2121
import java.util.stream.Stream;
2222

23-
import com.vaadin.flow.component.Component;
2423
import com.vaadin.flow.component.Tag;
2524
import com.vaadin.flow.component.dependency.JsModule;
2625
import com.vaadin.flow.component.dependency.NpmPackage;
@@ -29,7 +28,6 @@
2928
import com.vaadin.flow.data.provider.DataCommunicator;
3029
import com.vaadin.flow.data.provider.DataKeyMapper;
3130
import com.vaadin.flow.data.provider.DataProvider;
32-
import com.vaadin.flow.dom.Element;
3331
import com.vaadin.flow.function.SerializableBiPredicate;
3432

3533
import elemental.json.Json;
@@ -328,40 +326,4 @@ protected boolean isSelected(T item) {
328326
public T getEmptyValue() {
329327
return null;
330328
}
331-
332-
/**
333-
* Removes the given child components from this component.
334-
*
335-
* @param components
336-
* The components to remove.
337-
* @throws IllegalArgumentException
338-
* if any of the components is not a child of this component.
339-
* @deprecated since v23.3
340-
*/
341-
@Deprecated
342-
protected void remove(Component... components) {
343-
for (Component component : components) {
344-
if (getElement().equals(component.getElement().getParent())) {
345-
component.getElement().removeAttribute("slot");
346-
getElement().removeChild(component.getElement());
347-
} else {
348-
throw new IllegalArgumentException("The given component ("
349-
+ component + ") is not a child of this component");
350-
}
351-
}
352-
}
353-
354-
/**
355-
* Removes all contents from this component, this includes child components,
356-
* text content as well as child elements that have been added directly to
357-
* this component using the {@link Element} API.
358-
*
359-
* @deprecated since v23.3
360-
*/
361-
@Deprecated
362-
protected void removeAll() {
363-
getElement().getChildren()
364-
.forEach(child -> child.removeAttribute("slot"));
365-
getElement().removeAllChildren();
366-
}
367329
}

0 commit comments

Comments
 (0)