Skip to content

Commit 6b38428

Browse files
feat: add Tooltip support for SideNavItem (#7849)
1 parent 8063da3 commit 6b38428

File tree

3 files changed

+22
-2
lines changed
  • vaadin-side-nav-flow-parent
    • vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests
    • vaadin-side-nav-flow/src

3 files changed

+22
-2
lines changed

vaadin-side-nav-flow-parent/vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests/SideNavPage.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ public SideNavPage() {
4646
SideNavItem navigableParent = new SideNavItem("Navigable parent",
4747
"vaadin-side-nav/side-nav-test-target-view");
4848
navigableParent.setId("navigable-parent");
49+
navigableParent
50+
.setTooltipText("Parent of items that can be navigated to.");
4951
navigableParent.addItem(new SideNavItem("Item 1",
5052
"vaadin-side-nav/side-nav-test-target-view"));
5153
navigableParent.addItem(new SideNavItem("Item 2"));

vaadin-side-nav-flow-parent/vaadin-side-nav-flow/src/main/java/com/vaadin/flow/component/sidenav/SideNavItem.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import com.vaadin.flow.component.dependency.NpmPackage;
3434
import com.vaadin.flow.component.shared.HasPrefix;
3535
import com.vaadin.flow.component.shared.HasSuffix;
36+
import com.vaadin.flow.component.shared.HasTooltip;
3637
import com.vaadin.flow.dom.Element;
3738
import com.vaadin.flow.internal.JsonSerializer;
3839
import com.vaadin.flow.internal.UrlUtil;
@@ -59,8 +60,8 @@
5960
@Tag("vaadin-side-nav-item")
6061
@NpmPackage(value = "@vaadin/side-nav", version = "25.0.0-alpha16")
6162
@JsModule("@vaadin/side-nav/src/vaadin-side-nav-item.js")
62-
public class SideNavItem extends Component
63-
implements HasSideNavItems, HasEnabled, HasPrefix, HasSuffix {
63+
public class SideNavItem extends Component implements HasSideNavItems,
64+
HasEnabled, HasPrefix, HasSuffix, HasTooltip {
6465

6566
private Element labelElement;
6667

vaadin-side-nav-flow-parent/vaadin-side-nav-flow/src/test/java/com/vaadin/flow/component/sidenav/tests/SideNavItemTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import com.vaadin.flow.component.Component;
3232
import com.vaadin.flow.component.ComponentUtil;
3333
import com.vaadin.flow.component.html.Div;
34+
import com.vaadin.flow.component.shared.HasTooltip;
3435
import com.vaadin.flow.component.sidenav.SideNavItem;
3536
import com.vaadin.flow.dom.Element;
3637
import com.vaadin.flow.router.BeforeEvent;
@@ -218,6 +219,22 @@ public void createWithPathAndPrefix_pathAndPrefixIsSet() {
218219
Assert.assertEquals(prefixComponent, sideNavItem.getPrefixComponent());
219220
}
220221

222+
// TOOLTIP TESTS
223+
@Test
224+
public void implementsHasTooltip() {
225+
sideNavItem = new SideNavItem("Test item", "test-path");
226+
Assert.assertTrue(sideNavItem instanceof HasTooltip);
227+
}
228+
229+
@Test
230+
public void tooltipTextIsSet() {
231+
sideNavItem = new SideNavItem("Test item", "test-path");
232+
sideNavItem.setTooltipText("Test tooltip text");
233+
Assert.assertNotNull(sideNavItem.getTooltip());
234+
Assert.assertEquals("Test tooltip text",
235+
sideNavItem.getTooltip().getText());
236+
}
237+
221238
// EXPAND AND COLLAPSE TESTS
222239

223240
@Test

0 commit comments

Comments
 (0)