Skip to content

Commit 96dabb7

Browse files
authored
refactor: hide dashboard spacing api temporarily (#6831)
* refactor: hide dashboard spacing api temporarily * fix: make helpers public * fix: make helpers public * test: revert deletion of helper and use spacing property directly
1 parent ba11f24 commit 96dabb7

File tree

2 files changed

+5
-4
lines changed
  • vaadin-dashboard-flow-parent

2 files changed

+5
-4
lines changed

vaadin-dashboard-flow-parent/vaadin-dashboard-flow-integration-tests/src/main/java/com/vaadin/flow/component/dashboard/tests/DashboardItemResizePage.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ public DashboardItemResizePage() {
2626
dashboard.setMinimumRowHeight("200px");
2727
dashboard.setMinimumColumnWidth("250px");
2828
dashboard.setMaximumColumnWidth("250px");
29-
dashboard.setSpacing("0px");
29+
// Use setSpacing when it is made public
30+
getStyle().set("--vaadin-dashboard-spacing", "0px");
3031

3132
DashboardWidget widget = new DashboardWidget();
3233
widget.setTitle("Widget");

vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
* Dashboard is a responsive layout component that allows users to organize
4545
* widgets either directly within the dashboard or optionally group them into
4646
* sections. The component supports customizable layout options like maximum
47-
* column count and spacing.
47+
* column count.
4848
* <p>
4949
* Internationalization (i18n) is supported through {@link DashboardI18n},
5050
* allowing customization of accessible names for the dashboard controls. The
@@ -319,7 +319,7 @@ public void setMinimumRowHeight(String minRowHeight) {
319319
*
320320
* @return the spacing of the dashboard
321321
*/
322-
public String getSpacing() {
322+
String getSpacing() {
323323
return getStyle().get("--vaadin-dashboard-spacing");
324324
}
325325

@@ -331,7 +331,7 @@ public String getSpacing() {
331331
* the new spacing. Pass in {@code null} to set the spacing back
332332
* to the default value.
333333
*/
334-
public void setSpacing(String spacing) {
334+
void setSpacing(String spacing) {
335335
getStyle().set("--vaadin-dashboard-spacing", spacing);
336336
}
337337

0 commit comments

Comments
 (0)