Skip to content

Commit bd2e9c4

Browse files
web-padawanweb-padawan
authored
refactor!: rename SplitterDragendEvent and addSplitterDragendListener (#8112)
1 parent 4bb4be4 commit bd2e9c4

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

‎vaadin-split-layout-flow-parent/vaadin-split-layout-flow-integration-tests/src/main/java/com/vaadin/flow/component/splitlayout/test/SplitLayoutView.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private void addResizeNotificationLayout() {
6969

7070
Span message = new Span("Drag and drop the splitter");
7171
AtomicInteger resizeCounter = new AtomicInteger();
72-
layout.addSplitterDragendListener(
72+
layout.addSplitterDragEndListener(
7373
event -> message.setText("SplitLayout Resized "
7474
+ resizeCounter.incrementAndGet() + " times."));
7575

‎vaadin-split-layout-flow-parent/vaadin-split-layout-flow-integration-tests/src/main/java/com/vaadin/flow/component/splitlayout/test/SplitterPositionView.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ private void createLayoutJavaApi() {
6060

6161
Span showSplitterPosition = new Span();
6262
showSplitterPosition.setId("showSplitterPositionJavaApi");
63-
layout.addSplitterDragendListener(e -> showSplitterPosition
63+
layout.addSplitterDragEndListener(e -> showSplitterPosition
6464
.setText(String.valueOf(e.getSource().getSplitterPosition())));
6565
add(setSplitterPosition, layout, showSplitterPosition);
6666
}
@@ -83,7 +83,7 @@ private void createLayoutElementApi() {
8383

8484
Span showSplitterPosition = new Span();
8585
showSplitterPosition.setId("showSplitterPositionElementApi");
86-
layout.addSplitterDragendListener(e -> showSplitterPosition
86+
layout.addSplitterDragEndListener(e -> showSplitterPosition
8787
.setText(String.valueOf(e.getSource().getSplitterPosition())));
8888
add(setSplitterPosition, layout, showSplitterPosition);
8989
}

‎vaadin-split-layout-flow-parent/vaadin-split-layout-flow/src/main/java/com/vaadin/flow/component/splitlayout/SplitLayout.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public SplitLayout(Orientation orientation) {
7878
setOrientation(orientation);
7979
addAttachListener(
8080
e -> this.requestStylesUpdatesForSplitterPosition(e.getUI()));
81-
addSplitterDragendListener(e -> {
81+
addSplitterDragEndListener(e -> {
8282
splitterPosition = calcNewSplitterPosition(
8383
e.primaryComponentFlexBasis, e.secondaryComponentFlexBasis);
8484

@@ -210,7 +210,7 @@ public Component getSecondaryComponent() {
210210
* 0 and 100. The value will be null unless the splitter position has been
211211
* explicitly set on the server-side, or the splitter has been moved on the
212212
* client side. The splitter position is automatically updated when as part
213-
* of the {@link SplitterDragendEvent}.
213+
* of the {@link SplitterDragEndEvent}.
214214
*
215215
* @return the splitter position, may be null
216216
*/
@@ -339,7 +339,7 @@ public void removeAll() {
339339
}
340340

341341
@DomEvent("splitter-dragend")
342-
public static class SplitterDragendEvent
342+
public static class SplitterDragEndEvent
343343
extends ComponentEvent<SplitLayout> {
344344

345345
private static final String PRIMARY_FLEX_BASIS = "element.querySelector(':scope > [slot=\"primary\"]').style.flexBasis";
@@ -348,7 +348,7 @@ public static class SplitterDragendEvent
348348
String primaryComponentFlexBasis;
349349
String secondaryComponentFlexBasis;
350350

351-
public SplitterDragendEvent(SplitLayout source, boolean fromClient,
351+
public SplitterDragEndEvent(SplitLayout source, boolean fromClient,
352352
@EventData(PRIMARY_FLEX_BASIS) String primaryComponentFlexBasis,
353353
@EventData(SECONDARY_FLEX_BASIS) String secondaryComponentFlexBasis) {
354354
super(source, fromClient);
@@ -366,9 +366,9 @@ public SplitterDragendEvent(SplitLayout source, boolean fromClient,
366366
* the listener to add
367367
* @return a registration for removing the listener
368368
*/
369-
public Registration addSplitterDragendListener(
370-
ComponentEventListener<SplitterDragendEvent> listener) {
371-
return addListener(SplitterDragendEvent.class,
369+
public Registration addSplitterDragEndListener(
370+
ComponentEventListener<SplitterDragEndEvent> listener) {
371+
return addListener(SplitterDragEndEvent.class,
372372
(ComponentEventListener) listener);
373373
}
374374

‎vaadin-split-layout-flow-parent/vaadin-split-layout-flow/src/test/java/com/vaadin/flow/component/splitlayout/tests/SplitLayoutUnitTest.java‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
import com.vaadin.flow.component.html.Div;
2727
import com.vaadin.flow.component.html.Span;
2828
import com.vaadin.flow.component.splitlayout.SplitLayout;
29-
import com.vaadin.flow.component.splitlayout.SplitLayout.SplitterDragendEvent;
29+
import com.vaadin.flow.component.splitlayout.SplitLayout.SplitterDragEndEvent;
3030

3131
public class SplitLayoutUnitTest {
3232

@@ -156,7 +156,7 @@ public void testUpdateSplitterPosition_dragEndEvent_widthInPixels() {
156156
double splitterPosition = 45.66;
157157
splitLayout.setSplitterPosition(splitterPosition);
158158

159-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
159+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
160160
splitLayout, true, "432.68px", "267.32px"));
161161

162162
Assert.assertEquals(61.81, splitLayout.getSplitterPosition(), 0.01);
@@ -168,7 +168,7 @@ public void testUpdateSplitterPosition_dragEndEvent_widthInPercentage() {
168168
double splitterPosition = 45.66;
169169
splitLayout.setSplitterPosition(splitterPosition);
170170

171-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
171+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
172172
splitLayout, true, "58.23%", "41.77%"));
173173

174174
Assert.assertEquals(58.23, splitLayout.getSplitterPosition(), 0);
@@ -189,7 +189,7 @@ public void constructorWithOrientation() {
189189
double splitterPosition = 45.66;
190190
splitLayout.setSplitterPosition(splitterPosition);
191191

192-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
192+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
193193
splitLayout, true, "58.23%", "41.77%"));
194194

195195
Assert.assertEquals(58.23, splitLayout.getSplitterPosition(), 0);
@@ -206,7 +206,7 @@ public void constructorWithComponents() {
206206
double splitterPosition = 45.66;
207207
splitLayout.setSplitterPosition(splitterPosition);
208208

209-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
209+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
210210
splitLayout, true, "58.23%", "41.77%"));
211211

212212
Assert.assertEquals(58.23, splitLayout.getSplitterPosition(), 0);
@@ -227,7 +227,7 @@ public void constructorWithComponentsAndOrientation() {
227227
double splitterPosition = 45.66;
228228
splitLayout.setSplitterPosition(splitterPosition);
229229

230-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
230+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
231231
splitLayout, true, "58.23%", "41.77%"));
232232

233233
Assert.assertEquals(58.23, splitLayout.getSplitterPosition(), 0);
@@ -246,7 +246,7 @@ public void testUpdateSplitterPosition_dragEndEvent_primaryWidthNull() {
246246
splitLayout.setSplitterPosition(splitterPosition);
247247

248248
ComponentUtil.fireEvent(splitLayout,
249-
new SplitterDragendEvent(splitLayout, true, null, "41.77%"));
249+
new SplitterDragEndEvent(splitLayout, true, null, "41.77%"));
250250

251251
Assert.assertEquals(45.66, splitLayout.getSplitterPosition(), 0);
252252
}
@@ -258,7 +258,7 @@ public void testUpdateSplitterPosition_dragEndEvent_secondaryWidthNull() {
258258
splitLayout.setSplitterPosition(splitterPosition);
259259

260260
ComponentUtil.fireEvent(splitLayout,
261-
new SplitterDragendEvent(splitLayout, true, "41.77%", null));
261+
new SplitterDragEndEvent(splitLayout, true, "41.77%", null));
262262

263263
Assert.assertEquals(45.66, splitLayout.getSplitterPosition(), 0);
264264
}
@@ -267,7 +267,7 @@ public void testUpdateSplitterPosition_dragEndEvent_secondaryWidthNull() {
267267
public void testUpdateSplitterPosition_noInitialPosition() {
268268
SplitLayout splitLayout = new SplitLayout();
269269

270-
ComponentUtil.fireEvent(splitLayout, new SplitterDragendEvent(
270+
ComponentUtil.fireEvent(splitLayout, new SplitterDragEndEvent(
271271
splitLayout, true, "432.68px", "267.32px"));
272272

273273
Assert.assertEquals(61.81, splitLayout.getSplitterPosition(), 0.01);

0 commit comments

Comments
 (0)