Skip to content

Commit c0e1db9

Browse files
authored
fix: fix path to property in events (#8116)
The button property points to the wrong path in which it is located in the originalEvent object sent by the client. It seems that it didn't fail before, but lately, that has caused some IT failures, as the mapping from null to int now causes an exception that prevents the Java event objects from being instantiated.
1 parent 2d47993 commit c0e1db9

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/events/PointLegendItemClickEvent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public PointLegendItemClickEvent(Chart source, boolean fromClient,
4040
@EventData("event.detail.originalEvent.browserEvent.ctrlKey") boolean ctrlKey,
4141
@EventData("event.detail.originalEvent.browserEvent.metaKey") boolean metaKey,
4242
@EventData("event.detail.originalEvent.browserEvent.shiftKey") boolean shiftKey,
43-
@EventData("event.detail.originalEvent.button") int button,
43+
@EventData("event.detail.originalEvent.browserEvent.button") int button,
4444
@EventData("event.detail.point.series.index") int seriesIndex,
4545
@EventData("event.detail.point.category") String category,
4646
@EventData("event.detail.point.index") int pointIndex,

vaadin-charts-flow-parent/vaadin-charts-flow/src/main/java/com/vaadin/flow/component/charts/events/SeriesLegendItemClickEvent.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public SeriesLegendItemClickEvent(Chart source, boolean fromClient,
3737
@EventData("event.detail.originalEvent.browserEvent.ctrlKey") boolean ctrlKey,
3838
@EventData("event.detail.originalEvent.browserEvent.metaKey") boolean metaKey,
3939
@EventData("event.detail.originalEvent.browserEvent.shiftKey") boolean shiftKey,
40-
@EventData("event.detail.originalEvent.button") int button,
40+
@EventData("event.detail.originalEvent.browserEvent.button") int button,
4141
@EventData("event.detail.series.index") int seriesIndex) {
4242
super(source, fromClient);
4343
this.seriesIndex = seriesIndex;

0 commit comments

Comments
 (0)