Skip to content

Commit 03e75f8

Browse files
authored
refactor: remove Polymer specific logic from combo-box (#9234)
1 parent abd206d commit 03e75f8

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

packages/combo-box/src/vaadin-combo-box-mixin.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -428,25 +428,6 @@ export const ComboBoxMixin = (subclass) =>
428428
this.opened = false;
429429
}
430430

431-
/**
432-
* Override Polymer lifecycle callback to handle `filter` property change after
433-
* the observer for `opened` property is triggered. This is needed when opening
434-
* combo-box on user input to ensure the focused index is set correctly.
435-
*
436-
* @param {!Object} currentProps Current accessor values
437-
* @param {?Object} changedProps Properties changed since the last call
438-
* @param {?Object} oldProps Previous values for each changed property
439-
* @protected
440-
* @override
441-
*/
442-
_propertiesChanged(currentProps, changedProps, oldProps) {
443-
super._propertiesChanged(currentProps, changedProps, oldProps);
444-
445-
if (changedProps.filter !== undefined) {
446-
this._filterChanged(changedProps.filter);
447-
}
448-
}
449-
450431
/**
451432
* Override LitElement lifecycle callback to handle filter property change.
452433
* @param {Object} props

0 commit comments

Comments
 (0)