Skip to content

Commit 58d9759

Browse files
authored
feat: port avatar and avatar-group Lumo styles to CSS files (#9338)
1 parent d61c31d commit 58d9759

18 files changed

+314
-15
lines changed

dev/avatar-group.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
<script type="module" src="./common.js"></script>
99

1010
<script type="module">
11-
import '@vaadin/avatar-group/src/vaadin-avatar-group.js';
11+
import '@vaadin/avatar-group';
12+
import '@vaadin/vaadin-lumo-styles/lumo.css';
1213

1314
const groups = document.querySelectorAll('vaadin-avatar-group');
1415
groups.forEach(group => group.items = [{ name: 'AA' }, { name: 'BB' }, { name: 'CC' }, { name: 'DD' }]);

dev/avatar.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<script type="module">
1111
import '@vaadin/avatar';
1212
import '@vaadin/tooltip';
13+
import '@vaadin/vaadin-lumo-styles/lumo.css';
1314
</script>
1415
</head>
1516

packages/avatar-group/src/vaadin-avatar-group-menu-item.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { defineCustomElement } from '@vaadin/component-base/src/define.js';
88
import { DirMixin } from '@vaadin/component-base/src/dir-mixin.js';
99
import { PolylitMixin } from '@vaadin/component-base/src/polylit-mixin.js';
1010
import { ItemMixin } from '@vaadin/item/src/vaadin-item-mixin.js';
11+
import { CSSInjectionMixin } from '@vaadin/vaadin-themable-mixin/css-injection-mixin.js';
1112
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
1213
import { avatarGroupMenuItemStyles } from './styles/vaadin-avatar-group-menu-item-core-styles.js';
1314

@@ -21,7 +22,7 @@ import { avatarGroupMenuItemStyles } from './styles/vaadin-avatar-group-menu-ite
2122
* @mixes ThemableMixin
2223
* @protected
2324
*/
24-
class AvatarGroupMenuItem extends ItemMixin(ThemableMixin(DirMixin(PolylitMixin(LitElement)))) {
25+
class AvatarGroupMenuItem extends ItemMixin(ThemableMixin(DirMixin(CSSInjectionMixin(PolylitMixin(LitElement))))) {
2526
static get is() {
2627
return 'vaadin-avatar-group-menu-item';
2728
}

packages/avatar-group/src/vaadin-avatar-group-menu.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { ListMixin } from '@vaadin/a11y-base/src/list-mixin.js';
88
import { defineCustomElement } from '@vaadin/component-base/src/define.js';
99
import { DirMixin } from '@vaadin/component-base/src/dir-mixin.js';
1010
import { PolylitMixin } from '@vaadin/component-base/src/polylit-mixin.js';
11+
import { CSSInjectionMixin } from '@vaadin/vaadin-themable-mixin/css-injection-mixin.js';
1112
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
1213
import { avatarGroupMenuStyles } from './styles/vaadin-avatar-group-menu-core-styles.js';
1314

@@ -21,7 +22,7 @@ import { avatarGroupMenuStyles } from './styles/vaadin-avatar-group-menu-core-st
2122
* @mixes ThemableMixin
2223
* @protected
2324
*/
24-
class AvatarGroupMenu extends ListMixin(ThemableMixin(DirMixin(PolylitMixin(LitElement)))) {
25+
class AvatarGroupMenu extends ListMixin(ThemableMixin(DirMixin(CSSInjectionMixin(PolylitMixin(LitElement))))) {
2526
static get is() {
2627
return 'vaadin-avatar-group-menu';
2728
}

packages/avatar-group/src/vaadin-avatar-group-overlay.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { PolylitMixin } from '@vaadin/component-base/src/polylit-mixin.js';
1010
import { OverlayMixin } from '@vaadin/overlay/src/vaadin-overlay-mixin.js';
1111
import { PositionMixin } from '@vaadin/overlay/src/vaadin-overlay-position-mixin.js';
1212
import { overlayStyles } from '@vaadin/overlay/src/vaadin-overlay-styles.js';
13+
import { CSSInjectionMixin } from '@vaadin/vaadin-themable-mixin/css-injection-mixin.js';
1314
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
1415

1516
/**
@@ -23,7 +24,9 @@ import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mix
2324
* @mixes ThemableMixin
2425
* @private
2526
*/
26-
class AvatarGroupOverlay extends PositionMixin(OverlayMixin(DirMixin(ThemableMixin(PolylitMixin(LitElement))))) {
27+
class AvatarGroupOverlay extends PositionMixin(
28+
OverlayMixin(DirMixin(ThemableMixin(CSSInjectionMixin(PolylitMixin(LitElement))))),
29+
) {
2730
static get is() {
2831
return 'vaadin-avatar-group-overlay';
2932
}

packages/avatar-group/src/vaadin-avatar-group.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { html, LitElement } from 'lit';
1212
import { defineCustomElement } from '@vaadin/component-base/src/define.js';
1313
import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
1414
import { PolylitMixin } from '@vaadin/component-base/src/polylit-mixin.js';
15+
import { CSSInjectionMixin } from '@vaadin/vaadin-themable-mixin/css-injection-mixin.js';
1516
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
1617
import { avatarGroupStyles } from './styles/vaadin-avatar-group-core-styles.js';
1718
import { AvatarGroupMixin } from './vaadin-avatar-group-mixin.js';
@@ -62,7 +63,7 @@ import { AvatarGroupMixin } from './vaadin-avatar-group-mixin.js';
6263
* @mixes AvatarGroupMixin
6364
* @mixes ThemableMixin
6465
*/
65-
class AvatarGroup extends AvatarGroupMixin(ElementMixin(ThemableMixin(PolylitMixin(LitElement)))) {
66+
class AvatarGroup extends AvatarGroupMixin(ElementMixin(ThemableMixin(CSSInjectionMixin(PolylitMixin(LitElement))))) {
6667
static get is() {
6768
return 'vaadin-avatar-group';
6869
}

packages/avatar-group/test/visual/lumo/avatar-group.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import { fixtureSync, nextRender } from '@vaadin/testing-helpers';
22
import { visualDiff } from '@web/test-runner-visual-regression';
3-
import '../../../theme/lumo/vaadin-avatar-group.js';
3+
import '@vaadin/vaadin-lumo-styles/props.css';
4+
import '@vaadin/vaadin-lumo-styles/components/avatar.css';
5+
import '@vaadin/vaadin-lumo-styles/components/avatar-group.css';
6+
import '../../../vaadin-avatar-group.js';
47

58
describe('avatar-group', () => {
69
let div, element;

packages/avatar/src/vaadin-avatar.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { defineCustomElement } from '@vaadin/component-base/src/define.js';
1010
import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
1111
import { PolylitMixin } from '@vaadin/component-base/src/polylit-mixin.js';
1212
import { TooltipController } from '@vaadin/component-base/src/tooltip-controller.js';
13+
import { CSSInjectionMixin } from '@vaadin/vaadin-themable-mixin/css-injection-mixin.js';
1314
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
1415
import { avatarStyles } from './styles/vaadin-avatar-core-styles.js';
1516
import { AvatarMixin } from './vaadin-avatar-mixin.js';
@@ -46,7 +47,7 @@ import { AvatarMixin } from './vaadin-avatar-mixin.js';
4647
* @mixes ElementMixin
4748
* @mixes ThemableMixin
4849
*/
49-
class Avatar extends AvatarMixin(ElementMixin(ThemableMixin(PolylitMixin(LitElement)))) {
50+
class Avatar extends AvatarMixin(ElementMixin(ThemableMixin(CSSInjectionMixin(PolylitMixin(LitElement))))) {
5051
static get is() {
5152
return 'vaadin-avatar';
5253
}

packages/avatar/test/visual/lumo/avatar.test.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import { sendKeys } from '@vaadin/test-runner-commands';
2-
import { fixtureSync } from '@vaadin/testing-helpers/dist/fixture.js';
2+
import { fixtureSync } from '@vaadin/testing-helpers';
33
import { visualDiff } from '@web/test-runner-visual-regression';
4+
import '@vaadin/vaadin-lumo-styles/props.css';
5+
import '@vaadin/vaadin-lumo-styles/components/avatar.css';
6+
import '@vaadin/vaadin-lumo-styles/components/tooltip.css';
47
import '@vaadin/tooltip/test/not-animated-styles.js';
5-
import '../../../theme/lumo/vaadin-avatar.js';
8+
import '../../../vaadin-avatar.js';
69
import { Tooltip } from '@vaadin/tooltip/src/vaadin-tooltip.js';
710

811
describe('avatar', () => {

packages/vaadin-lumo-styles/components.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
55
*/
66
@import './components/accordion.css';
7+
@import './components/avatar-group.css';
8+
@import './components/avatar.css';
79
@import './components/button.css';
810
@import './components/checkbox-group.css';
911
@import './components/checkbox.css';

0 commit comments

Comments
 (0)