Skip to content

Commit 615365c

Browse files
authored
fix: do not show required indicator when checkbox has no label (#8294)
1 parent 63018cc commit 615365c

File tree

6 files changed

+20
-0
lines changed

6 files changed

+20
-0
lines changed

packages/checkbox/test/visual/lumo/checkbox.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@ describe('checkbox', () => {
5050
await visualDiff(div, 'required');
5151
});
5252

53+
it('required empty', async () => {
54+
element.required = true;
55+
element.label = '';
56+
await visualDiff(div, 'required-empty');
57+
});
58+
5359
it('invalid focus-ring', async () => {
5460
element.required = true;
5561
element.invalid = true;
278 Bytes
Loading

packages/checkbox/test/visual/material/checkbox.test.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,12 @@ describe('checkbox', () => {
4949
await visualDiff(div, 'required');
5050
});
5151

52+
it('required empty', async () => {
53+
element.required = true;
54+
element.label = '';
55+
await visualDiff(div, 'required-empty');
56+
});
57+
5258
it('error message', async () => {
5359
element.errorMessage = 'This field is required';
5460
element.required = true;
256 Bytes
Loading

packages/checkbox/theme/lumo/vaadin-checkbox-styles.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,10 @@ registerStyles(
241241
text-align: center;
242242
}
243243
244+
:host(:not([has-label])) [part='required-indicator'] {
245+
display: none;
246+
}
247+
244248
/* Invalid */
245249
:host([invalid]) {
246250
--vaadin-input-field-border-color: var(--lumo-error-color);

packages/checkbox/theme/material/vaadin-checkbox-styles.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,10 @@ registerStyles(
161161
color: var(--material-error-text-color);
162162
}
163163
164+
:host(:not([has-label])) [part='required-indicator'] {
165+
display: none;
166+
}
167+
164168
[part='error-message'],
165169
[part='helper-text'] {
166170
font-size: 0.75em;

0 commit comments

Comments
 (0)