Skip to content

Commit a9ff39d

Browse files
authored
fix: add missing section type to dashboard events (#8325)
* fix: add missing section type to dashboard events * revert type for resize move changed event
1 parent 2f7bc89 commit a9ff39d

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

packages/dashboard/src/vaadin-dashboard.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export type DashboardRenderer<TItem extends DashboardItem> = (
6868
* Fired when an item was moved
6969
*/
7070
export type DashboardItemMovedEvent<TItem extends DashboardItem> = CustomEvent<{
71-
item: TItem;
71+
item: TItem | DashboardSectionItem<TItem>;
7272

7373
items: Array<TItem | DashboardSectionItem<TItem>>;
7474

@@ -97,15 +97,15 @@ export type DashboardItemRemovedEvent<TItem extends DashboardItem> = CustomEvent
9797
* Fired when an item selected state changed
9898
*/
9999
export type DashboardItemSelectedChangedEvent<TItem extends DashboardItem> = CustomEvent<{
100-
item: TItem;
100+
item: TItem | DashboardSectionItem<TItem>;
101101
value: boolean;
102102
}>;
103103

104104
/**
105105
* Fired when an item move mode changed
106106
*/
107107
export type DashboardItemMoveModeChangedEvent<TItem extends DashboardItem> = CustomEvent<{
108-
item: TItem;
108+
item: TItem | DashboardSectionItem<TItem>;
109109
value: boolean;
110110
}>;
111111

packages/dashboard/test/typings/dashboard.types.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(s
7575

7676
narrowedDashboard.addEventListener('dashboard-item-moved', (event) => {
7777
assertType<DashboardItemMovedEvent<TestDashboardItem>>(event);
78-
assertType<TestDashboardItem>(event.detail.item);
78+
assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
79+
assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
7980
assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(event.detail.items);
8081
assertType<DashboardSectionItem<TestDashboardItem> | undefined>(event.detail.section);
8182
});
@@ -88,19 +89,22 @@ narrowedDashboard.addEventListener('dashboard-item-resized', (event) => {
8889

8990
narrowedDashboard.addEventListener('dashboard-item-removed', (event) => {
9091
assertType<DashboardItemRemovedEvent<TestDashboardItem>>(event);
91-
assertType<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>(event.detail.item);
92+
assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
93+
assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
9294
assertType<Array<TestDashboardItem | DashboardSectionItem<TestDashboardItem>>>(event.detail.items);
9395
});
9496

9597
narrowedDashboard.addEventListener('dashboard-item-selected-changed', (event) => {
9698
assertType<DashboardItemSelectedChangedEvent<TestDashboardItem>>(event);
97-
assertType<TestDashboardItem>(event.detail.item);
99+
assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
100+
assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
98101
assertType<boolean>(event.detail.value);
99102
});
100103

101104
narrowedDashboard.addEventListener('dashboard-item-move-mode-changed', (event) => {
102105
assertType<DashboardItemMoveModeChangedEvent<TestDashboardItem>>(event);
103-
assertType<TestDashboardItem>(event.detail.item);
106+
assertType<TestDashboardItem>(event.detail.item as TestDashboardItem);
107+
assertType<DashboardSectionItem<TestDashboardItem>>(event.detail.item as DashboardSectionItem<TestDashboardItem>);
104108
assertType<boolean>(event.detail.value);
105109
});
106110

0 commit comments

Comments
 (0)