fix: postpone registration until first instance is created (#11354)

web-padawan · web-flow · commit b7ed99ffb38e · 2026-03-13T09:40:35.000+01:00
* fix: postpone registtration until first instance is created

* chore: remove protected finalize method from typings

* test: ensure registrations is empty before element is created
diff --git a/packages/component-base/src/element-mixin.d.ts b/packages/component-base/src/element-mixin.d.ts
@@ -18,6 +18,4 @@ export declare function ElementMixin<T extends Constructor<HTMLElement>>(
 export declare class ElementMixinClass {
   static is: string;
   static version: string;
-
-  protected static finalize(): void;
 }
diff --git a/packages/component-base/src/element-mixin.js b/packages/component-base/src/element-mixin.js
@@ -38,9 +38,7 @@ const registered = new Set();
 export const ElementMixin = (superClass) =>
   class VaadinElementMixin extends DirMixin(superClass) {
     /** @protected */
-    static finalize() {
-      super.finalize();
-
+    static _ensureRegistrations() {
       const { is } = this;
 
       // Registers a class prototype for telemetry purposes.
@@ -66,5 +64,7 @@ export const ElementMixin = (superClass) =>
           'Vaadin components require the "standards mode" declaration. Please add <!DOCTYPE html> to the HTML document.',
         );
       }
+
+      this.constructor._ensureRegistrations();
     }
   };
diff --git a/packages/component-base/test/element-mixin.test.js b/packages/component-base/test/element-mixin.test.js
@@ -40,9 +40,11 @@ describe('ElementMixin', () => {
 
     before(() => {
       ElementFoo = defineCE('element-foo');
+      flush();
     });
 
     it('should store the class entry in registrations once instance created', () => {
+      expect(window.Vaadin.registrations.length).to.equal(0);
       document.createElement(ElementFoo.is);
       flush();
       expect(window.Vaadin.registrations).to.be.instanceOf(Array);

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,4 @@ export declare function ElementMixin<T extends Constructor<HTMLElement>>(`
`18`	`18`	`export declare class ElementMixinClass {`
`19`	`19`	`static is: string;`
`20`	`20`	`static version: string;`
`21`		`-`
`22`		`- protected static finalize(): void;`
`23`	`21`	`}`