LinkChecker: Use logging instead of direct printing into console

Author: valery1707

build.gradle.kts

@@ -27,6 +27,9 @@ repositories {
 dependencies {
   implementation(libs.jackson.databind)
   implementation(libs.mockneat)
+  implementation(libs.bundles.logger.api)
+
+  runtimeOnly(libs.logger.impl)
 
   testImplementation(kotlin("test"))
   testImplementation(platform(libs.junit))

gradle/libs.versions.toml

@@ -11,8 +11,12 @@ junit = { module = "org.junit:junit-bom", version.ref = "junit" }
 assertj = { module = "org.assertj:assertj-core", version = "3.23.1" }
 mockneat = { module = "net.andreinc:mockneat", version = "0.4.8" }
 jmh-ann = { module = "org.openjdk.jmh:jmh-generator-annprocess", version.ref = "jmh.tools" }
+logger-api4j = { module = "org.slf4j:slf4j-api", version = "2.0.6" }
+logger-api4k = { module = "io.github.microutils:kotlin-logging-jvm", version = "3.0.4" }
+logger-impl = { module = "ch.qos.logback:logback-classic", version = "1.4.5" }
 
 [bundles]
+logger-api = ["logger.api4j", "logger.api4k"]
 
 [plugins]
 jmh = { id = "me.champeau.jmh", version = "0.6.8" }

src/main/kotlin/name/valery1707/problem/LinkChecker.kt

@@ -40,7 +40,7 @@ class LinkChecker(private val root: Path) {
             .filter { it.second.second.first != 200 }
             .toList()
         // todo remove
-        println("filePos2uriCheck = $filePos2uriCheck")
+        logger.debug { "filePos2uriCheck = $filePos2uriCheck" }
         return filePos2uriCheck
             .associateBy(
                 { "${it.first.first}:${it.first.second}" },
@@ -59,6 +59,8 @@ class LinkChecker(private val root: Path) {
     }
 
     companion object {
+        private val logger = mu.KotlinLogging.logger {}
+
         /**
          * https://stackoverflow.com/a/45690571
          */
@@ -104,8 +106,7 @@ class LinkChecker(private val root: Path) {
             val request = HttpRequest.newBuilder(this).GET().build()
             // todo Cache
             return try {
-                // todo Logging
-                println("Check: $this")
+                logger.info("Check: $this")
                 val response = client.send(request, HttpResponse.BodyHandlers.discarding())
                 when (response.statusCode()) {
                     //Redirects: extract new location
@@ -128,16 +129,15 @@ class LinkChecker(private val root: Path) {
 
                             ?: 500
 
-                        // todo Logging
-                        println("Await: $await ms")
+                        logger.debug("Await: $await ms")
                         Thread.sleep(await)
                         check(client)
                     }
 
                     else -> response.statusCode() to response.uri()
                 }
             } catch (e: Exception) {
-                // todo Logging
+                logger.error(e) { "Handle error on checking $this" }
                 -1 to URI.create("http://host?message=${e.message?.replace(" ", "%20")}")
             }
         }