Skip to content

Commit a221fe3

Browse files
authored
Merge pull request #9 from mbaldessari/ansible
Fix Ansible linting job
2 parents defe85b + 2952de5 commit a221fe3

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.ansible-lint

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ warn_list:
1919

2020
skip_list:
2121
- var-naming[no-role-prefix]
22+
- no-changed-when

ansible/odf_fix_dataimportcrons.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
- name: Exit if normal version check is not right
2222
ansible.builtin.meta: end_play
23-
when: cluster_version not in [ '4.16', 'UNSET' ]
23+
when: cluster_version not in ['4.16', 'UNSET']
2424

2525
- name: Find default storageclass
2626
ansible.builtin.shell: |
@@ -70,7 +70,7 @@
7070

7171
- name: Extract dic names
7272
ansible.builtin.set_fact:
73-
dic_names: "{{ dic_names | default([]) + [ item.metadata.name ] }}"
73+
dic_names: "{{ dic_names | default([]) + [item.metadata.name] }}"
7474
loop: "{{ dic_list.resources }}"
7575

7676
- name: Show names
@@ -91,8 +91,8 @@
9191

9292
- name: Record datasources that need cleanup
9393
ansible.builtin.set_fact:
94-
cron_cleanups: "{{ cron_cleanups + [ item.metadata.labels['cdi.kubevirt.io/dataImportCron'] ] }}"
95-
ds_cleanups: "{{ ds_cleanups + [ item.metadata.name ] }}"
94+
cron_cleanups: "{{ cron_cleanups + [item.metadata.labels['cdi.kubevirt.io/dataImportCron']] }}"
95+
ds_cleanups: "{{ ds_cleanups + [item.metadata.name] }}"
9696
loop: "{{ ds_cleanup_list.resources }}"
9797
when:
9898
- item['metadata']['labels']['cdi.kubevirt.io/dataImportCron'] is defined

0 commit comments

Comments
 (0)