Skip to content

Commit cdf1fac

Browse files
committed
Fix a bunch of super-linter
1 parent 3205f38 commit cdf1fac

File tree

2 files changed

+31
-23
lines changed

2 files changed

+31
-23
lines changed

.github/workflows/superlinter.yml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,24 @@ jobs:
2121
# Run Linter against code base #
2222
################################
2323
- name: Lint Code Base
24-
uses: github/super-linter/slim@v5
24+
uses: super-linter/super-linter/slim@v7
2525
env:
2626
VALIDATE_ALL_CODEBASE: true
2727
DEFAULT_BRANCH: main
2828
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
29-
# These are the validation we disable atm
29+
VALIDATE_ANSIBLE: false
3030
VALIDATE_BASH: false
31+
VALIDATE_CHECKOV: false
32+
VALIDATE_DOCKERFILE_HADOLINT: false
33+
VALIDATE_GOOGLE_JAVA_FORMAT: false
34+
VALIDATE_JAVA: false
3135
VALIDATE_JSCPD: false
3236
VALIDATE_KUBERNETES_KUBECONFORM: false
37+
VALIDATE_MARKDOWN_PRETTIER: false
38+
VALIDATE_PYTHON_PYLINT: false
39+
VALIDATE_SHELL_SHFMT: false
40+
VALIDATE_TEKTON: false
3341
VALIDATE_YAML: false
34-
VALIDATE_ANSIBLE: false
35-
VALIDATE_DOCKERFILE_HADOLINT: false
42+
VALIDATE_YAML_PRETTIER: false
3643
# VALIDATE_MARKDOWN: false
3744
# VALIDATE_NATURAL_LANGUAGE: false
38-
#VALIDATE_TEKTON: false

README.md

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,45 +12,47 @@ or how to use it, head over to [Ansible Edge GitOps](http://validatedpatterns.io
1212
This Validated Pattern lays the OTEL based infrastructure foundation to setup observability in federated and/or distributed environments.
1313
The infrastructure components are a central OpenShift Hub server with 4 edge nodes which are running as preconfigured virtual machines on OpenShift-Virtualization (OCP-V).
1414

15-
The technology components used here are
15+
The technology components used here are
16+
1617
- OpenShift,
1718
- ArgoCD as OpenShift GitOps,
1819
- Hashicorp Vault,
19-
- OpenShift Virtualization,
20+
- OpenShift Virtualization,
2021
- Ansible Automation Platform,
2122
- OpenShift Data Foundations (ODF),
2223
- Red Hat Device Edge (running at the edge),
2324
- OpenTelemetry.
2425

25-
The installation at the OpenShift hub cluster happens via Operators (subscriptions), the pattern itself (see values-hub.yaml) or via an Ansible playbook (OTEL at the edge) while the installation at the edge happens via an Ansible playbook installing an RPM: https://github.com/validatedpatterns-demos/rhvp.federated_edge_observability/blob/main/roles/otel_collector/tasks/main.yml
26+
The installation at the OpenShift hub cluster happens via Operators
27+
(subscriptions), the pattern itself (see values-hub.yaml) or via an Ansible
28+
playbook (OTEL at the edge) while the installation at the edge happens via an
29+
Ansible playbook installing an [RPM](https://github.com/validatedpatterns-demos/rhvp.federated_edge_observability/blob/main/roles/otel_collector/tasks/main.yml)
2630
ArgoCD is managing the applications as defined in the values-hub.yaml file.
2731

2832
The user/password/key config happens in your user home (!) directory via the values-secret.yaml, so make sure you copy and then edit your values-secret.yaml.template to ~/values-secret.yaml.
2933

30-
There are several different git repositories in play which serve different purposes. The multiple git repos serve the purpose of easy customization and adoption into different environments.
34+
There are several different Git repositories in play which serve different purposes. The multiple Git repositories serve the purpose of easy customization and adoption into different environments.
3135

3236
### GitRepos setup
3337

34-
#### Federated Edge Observability
35-
This pattern repo is the starting point and main git repo:
36-
https://github.com/validatedpatterns-sandbox/federated-edge-observability
38+
#### Federated Edge Observability Git
39+
40+
This pattern repository is the starting point and main Git repository:
41+
[Main repository](https://github.com/validatedpatterns-sandbox/federated-edge-observability)
3742

3843
The edge node setup is stored under $patterDir/overrides/values-egv-feo.yaml
3944

4045
#### RHVP Federated Edge Observability
41-
This pattern repo contains roles & Ansible playbooks for the edge device configuration:
42-
https://github.com/validatedpatterns-demos/rhvp.federated_edge_observability
43-
44-
#### Config as Code
45-
This repo holds the AAP configuration
46-
https://github.com/validatedpatterns-demos/federated-edge-observability-config-as-code
47-
48-
#### Edge Inventory
49-
This git repo holds the edge inventory
50-
https://github.com/validatedpatterns-demos/federated-edge-observability-inventory
51-
5246

47+
This pattern repository contains roles & Ansible playbooks for the edge device configuration:
48+
[Edge Device Configuration](https://github.com/validatedpatterns-demos/rhvp.federated_edge_observability)
5349

50+
#### Config as Code
5451

52+
This repository holds the AAP configuration
53+
[AAP Configuration](https://github.com/validatedpatterns-demos/federated-edge-observability-config-as-code)
5554

55+
#### Edge Inventory
5656

57+
This Git repository holds the edge inventory
58+
[Edge Inventory](https://github.com/validatedpatterns-demos/federated-edge-observability-inventory)

0 commit comments

Comments
 (0)