Skip to content

Commit 6f62ccc

Browse files
authored
use public mssql image and simplify ci pipeline (#12)
1 parent c8cf75b commit 6f62ccc

File tree

2 files changed

+24
-39
lines changed

2 files changed

+24
-39
lines changed

.github/workflows/ci-pipeline.yaml

Lines changed: 5 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -49,36 +49,15 @@ jobs:
4949
name: test-image
5050
path: image.tar
5151

52-
check-secrets:
53-
runs-on: ubuntu-latest
54-
outputs:
55-
mssql-available: ${{ steps.check-mssql.outputs.defined }}
56-
steps:
57-
- id: check-mssql
58-
env:
59-
REGISTRY: ${{ secrets.MSSQL_VECTOR_REGISTRY }}
60-
run: |
61-
if [[ -n "$REGISTRY" ]]; then
62-
echo "defined=true" >> "$GITHUB_OUTPUT"
63-
else
64-
echo "defined=false" >> "$GITHUB_OUTPUT"
65-
fi
66-
6752
test:
68-
needs: [lint, build, check-secrets]
53+
needs: [lint, build]
6954
runs-on: ubuntu-latest
7055
strategy:
7156
fail-fast: false
7257
matrix:
7358
db: [pgvector, redis, elastic, qdrant, mssql]
7459

7560
steps:
76-
- name: Early skip MSSQL if secrets unavailable
77-
if: matrix.db == 'mssql' && needs.check-secrets.outputs.mssql-available != 'true'
78-
run: |
79-
echo "Skipping MSSQL test: secrets missing."
80-
exit 78
81-
8261
- uses: actions/checkout@v4
8362

8463
- name: Download image artifact
@@ -90,27 +69,14 @@ jobs:
9069
- name: Load Docker image
9170
run: docker load -i image.tar
9271

93-
- name: Log in to registry for SQL-vector preview
94-
if: matrix.db == 'mssql'
95-
uses: docker/login-action@v3
96-
with:
97-
registry: ${{ secrets.MSSQL_VECTOR_REGISTRY }}
98-
username: ${{ secrets.MSSQL_VECTOR_USERNAME }}
99-
password: ${{ secrets.MSSQL_VECTOR_PASSWORD }}
100-
101-
- name: Pull preview SQL Server-vector image
102-
if: matrix.db == 'mssql'
103-
run: |
104-
docker pull ${{ secrets.MSSQL_VECTOR_REGISTRY }}/mssql-sql2025-ctp1-3-release/mssql-server-rhel9:17.0.400.5_4
105-
106-
- name: Start SQL Server-vector
72+
- name: Start MSSQL
10773
if: matrix.db == 'mssql'
10874
run: |
10975
docker run -d --name mssql-vector-test \
110-
-e ACCEPT_EULA=Y \
111-
-e SA_PASSWORD=StrongPassword! \
76+
-e "ACCEPT_EULA=Y" \
77+
-e "SA_PASSWORD=StrongPassword!" \
11278
-p 1433:1433 \
113-
${{ secrets.MSSQL_VECTOR_REGISTRY }}/mssql-sql2025-ctp1-3-release/mssql-server-rhel9:17.0.400.5_4
79+
mcr.microsoft.com/mssql/rhel/server:2025-latest
11480
11581
- name: Start PGVector
11682
if: matrix.db == 'pgvector'

README.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ It supports Git repositories, web URLs, and file types like Markdown, PDFs, and
2424
- [Elasticsearch](#elasticsearch)
2525
- [Redis (RediSearch)](#redis-redisearch)
2626
- [Qdrant](#qdrant)
27+
- [SQL Server (MSSQL)](#sql-server-mssql)
2728
- [🙌 Acknowledgments](#-acknowledgments)
2829

2930
---
@@ -242,6 +243,24 @@ DB_TYPE=QDRANT ./embed_documents.py
242243

243244
---
244245

246+
### SQL Server (MSSQL)
247+
248+
249+
```bash
250+
podman run --rm -d \
251+
--name mssql \
252+
-e ACCEPT_EULA=Y \
253+
-e SA_PASSWORD=StrongPassword! \
254+
-p 1433:1433 \
255+
mcr.microsoft.com/mssql/rhel/server:2025-latest
256+
````
257+
258+
```bash
259+
DB_TYPE=MSSQL ./embed_documents.py
260+
```
261+
262+
---
263+
245264
## 🙌 Acknowledgments
246265

247266
Built with:

0 commit comments

Comments
 (0)