Issue with the labels off in taskbar and advanced mitigations for classic theme enabled

[OrthodoxWindows]

@valinet First of all, I want to thank you for your programs. It is absolutely great.

Secondly, i have a bug when the labels are hidden and the advanced mitigations for classic theme, and the classic theme, is enabled.
More precisely, the buttons seems too wide.
It seems to me that the taskbar is set to occupy all available space :

With the labels displayed, the issue disappears :

The Explorer Patcher version is 22000.493.42.16.

[valinet]

Yeah, it’s a known issue, when classic theme is enabled, the themes functions in the OS do not work; specifically stuff from uxtheme. Explorer uses some functions from there to calculate the size of the buttons. For classic theme with button labels, I fixed this manually (that’s what the mitigations are). For classic theme without button labels, this simply hasn’t been tackled by anyone, so it just is in its default, broken state.

[OrthodoxWindows]

I think this broken state is not only related to the default state, but also related to classic theme mitigations, because the the icons do not behave the same way with the classic theme without taskbar mitigations and OpenShell patched DLL.

Below is a comparison of the different states of the taskbar:

https://ncloud5.zaclys.com/index.php/s/ox9kt2PHkJowYiJ/preview
Taskbar with ExplorerPatcher with labels, with classic theme, without mitigations, without OpenShell : the labels are gone, and the color is not customizable.

https://ncloud5.zaclys.com/index.php/s/gT4agBxnomDa5H7/preview
Taskbar with ExplorerPatcher without labels, with classic theme, without mitigations, without OpenShell : the icons are too tight, and the color is not customizable.

https://ncloud5.zaclys.com/index.php/s/dS3F97y6LkPTyTw/preview
Taskbar with ExplorerPatcher with labels, with classic theme, without mitigations, with OpenShell, without OpenShell taskbar customization : the labels are gone, and the color is not customizable.

https://ncloud5.zaclys.com/index.php/s/g6qgxY6saAXYMiG/preview
Taskbar with ExplorerPatcher without labels, with classic theme, without mitigations, with OpenShell, without OpenShell taskbar customization : the icons are too tight, and the color is not customizable.

https://ncloud5.zaclys.com/index.php/s/KDTKk7f37DbiB5z/preview
Taskbar with ExplorerPatcher with labels, with classic theme, without mitigations, with OpenShell, with OpenShell taskbar customization : the labels are gone, the color can be selected to be the same as the windows, but this is not automatic.

https://ncloud5.zaclys.com/index.php/s/7XoLw4FroqQqGxJ/preview
Taskbar with ExplorerPatcher without labels, with classic theme, without mitigations, with OpenShell, with OpenShell taskbar customization : the icons the icons are too tight, and the color can be selected to be the same as the windows, but this is not automatic.

https://ncloud5.zaclys.com/index.php/s/CXGLMF9CjpYYS5n/preview
Taskbar with ExplorerPatcher without labels, with classic theme, with mitigations and OpenShell custom DLL, with OpenShell, with OpenShell taskbar customization : the labels are present, and the background color is aligned with the window color.

https://ncloud5.zaclys.com/index.php/s/iBkYFXE2LEdTobn/preview
Taskbar with ExplorerPatcher without labels, with classic theme, with mitigations and OpenShell custom DLL, with OpenShell, without OpenShell taskbar customization : the background color is aligned with the window color, but the icons take up too much space.

[valinet]

Links do not work

[OrthodoxWindows]

I corrected, thank.

[valinet]

Secondly, i have a bug when the labels are hidden and the advanced mitigations for classic theme, and the classic theme, is enabled.
More precisely, the buttons seems too wide.

It's a bug in explorer.exe itself, or rather, it being unable to correctly query the sizes for the buttons because theme functions do not work. For labeled taskbar, that's what the "mitigations" in EP do: they fill in the gap and compute the widths another way so that explorer.exe gets what it wants. I couldn't make it work for label-less buttons though, hence the current broken state.