Fixed catastrophic bug that fragmented the heap, because I was accessing recently freed memory

valinet · valinet · commit 4cd727a1e530 · 2021-11-14T18:24:56.000+02:00
diff --git a/SimpleWindowSwitcher/sws_WindowSwitcher.c b/SimpleWindowSwitcher/sws_WindowSwitcher.c
@@ -497,6 +497,8 @@ static sws_window _sws_WindowSwitcher_WindowList_PushToFront(sws_WindowSwitcher*
         sws_window zero;
         ZeroMemory(&zero, sizeof(sws_window));
         sws_vector_PushBack(&(_this->pHWNDList), &zero);
+        // Reaquire list as vector may have been reallocated
+        pHWNDList = _this->pHWNDList.pList;
         for (int i = _this->pHWNDList.cbSize - 1; i > 0; i--)
         {
             pHWNDList[i] = pHWNDList[i - 1];

Original file line number	Diff line number	Diff line change
`@@ -497,6 +497,8 @@ static sws_window _sws_WindowSwitcher_WindowList_PushToFront(sws_WindowSwitcher*`
`497`	`497`	`sws_window zero;`
`498`	`498`	`ZeroMemory(&zero, sizeof(sws_window));`
`499`	`499`	`sws_vector_PushBack(&(_this->pHWNDList), &zero);`
	`500`	`+ // Reaquire list as vector may have been reallocated`
	`501`	`+ pHWNDList = _this->pHWNDList.pList;`
`500`	`502`	`for (int i = _this->pHWNDList.cbSize - 1; i > 0; i--)`
`501`	`503`	`{`
`502`	`504`	`pHWNDList[i] = pHWNDList[i - 1];`