Skip to content

Commit 4321821

Browse files
authored
TD-834: Fixes cascade with user interaction transiency in session (#112)
1 parent 507084b commit 4321821

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

apps/hellgate/src/hg_cascade.erl

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,16 @@ handle_trigger_check(negative_trigger) ->
4242

4343
is_user_interaction_triggered(undefined, _, _) ->
4444
not_triggered;
45-
is_user_interaction_triggered(
46-
#domain_CascadeWhenNoUI{}, Route, Sessions
47-
) ->
45+
is_user_interaction_triggered(#domain_CascadeWhenNoUI{}, Route, Sessions) ->
4846
is_user_interaction_triggered_(Route, Sessions).
4947

5048
is_user_interaction_triggered_(Route, Sessions) ->
5149
lists:foldl(
52-
fun(Session, Status) ->
53-
case Session of
54-
#{route := Route, interaction := Interaction} when Interaction =/= undefined ->
55-
negative_trigger;
56-
_ ->
57-
Status
58-
end
50+
fun
51+
(#{route := SessionRoute, ui_occurred := true}, _Status) when SessionRoute =:= Route ->
52+
negative_trigger;
53+
(_Session, Status) ->
54+
Status
5955
end,
6056
triggered,
6157
Sessions

apps/hellgate/src/hg_session.erl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
result => session_result(),
1818
proxy_state => proxy_state(),
1919
interaction => interaction(),
20+
ui_occurred => boolean(),
2021
timings => timings(),
2122
repair_scenario => repair_scenario()
2223
}.
@@ -413,7 +414,7 @@ apply_event(?proxy_st_changed(ProxyState), Session, _Context) ->
413414
apply_event(?interaction_changed(UserInteraction, Status), Session, _Context) ->
414415
case genlib:define(Status, ?interaction_requested) of
415416
?interaction_requested ->
416-
Session#{interaction => UserInteraction};
417+
Session#{interaction => UserInteraction, ui_occurred => true};
417418
?interaction_completed ->
418419
{UserInteraction, Session1} = maps:take(interaction, Session),
419420
Session1

0 commit comments

Comments
 (0)