Skip to content

Commit 32b0218

Browse files
authored
Fixing creation of server in test_rdb_restore_non_bloom_compatibility so exit does not need to be called (#58)
Signed-off-by: zackcam <[email protected]>
1 parent 148930e commit 32b0218

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

tests/test_bloom_save_and_restore.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,8 @@ def test_rdb_restore_non_bloom_compatibility(self):
112112
rdb_file = self.server.args["dbfilename"]
113113

114114
# Create a server without bloom-module
115-
new_server = ValkeyServerHandle(bind_ip=self.get_bind_ip(), port=self.get_bind_port(), port_tracker=self.port_tracker,
116-
cwd=self.testdir, server_path=self.server_path)
117-
new_server.set_startup_args({"dbfilename": rdb_file})
118-
new_server.start()
115+
new_server, new_client = self.create_server(testdir=self.testdir, server_path=self.server_path, args= {"dbfilename": rdb_file})
119116
assert new_server.is_alive()
120-
new_client = new_server.get_new_client()
121117
wait_for_equal(lambda: new_server.is_rdb_done_loading(), True)
122118

123119
# Verification
@@ -130,4 +126,3 @@ def test_rdb_restore_non_bloom_compatibility(self):
130126

131127
assert self.server.num_keys(client=new_client) == 1
132128
assert new_client.get("string") == b"val"
133-
new_server.exit()

0 commit comments

Comments
 (0)