Disable client setname and select operations (#42)

Temporarily disable these features due to a bug in glide core.

Signed-off-by: James Duong <[email protected]>

Author: jduo

tests/ValkeyGlideClusterTest.php

@@ -382,7 +382,7 @@ public function testClient()
     {
         $key = 'key-' . rand(1, 100);
 
-        $this->assertTrue($this->valkey_glide->client($key, 'setname', 'cluster_tests'));
+//        $this->assertTrue($this->valkey_glide->client($key, 'setname', 'cluster_tests'));
 
         $clients = $this->valkey_glide->client($key, 'list');
         $this->assertIsArray($clients);
@@ -397,10 +397,10 @@ public function testClient()
         }
 
         /* We should be in there */
-        $this->assertIsString($addr);
+//        $this->assertIsString($addr);
 
         /* Kill our own client! */
-        $this->assertTrue($this->valkey_glide->client($key, 'kill', $addr));
+//        $this->assertTrue($this->valkey_glide->client($key, 'kill', $addr));
     }
 
     public function testTime()

tests/ValkeyGlideTest.php

@@ -1590,22 +1590,23 @@ public function testMove()
         $value2 = 'test_value2';
 
         // Ensure we're in database 0
-        $this->valkey_glide->select(0);
+//        $this->valkey_glide->select(0);
 
         // Clean up any existing keys
         $this->valkey_glide->del($key1, $key2);
-        $this->valkey_glide->select(1);
+//        $this->valkey_glide->select(1);
         $this->valkey_glide->del($key1, $key2);
-        $this->valkey_glide->select(0);
+//        $this->valkey_glide->select(0);
 
         // Test successful move
         $this->valkey_glide->set($key1, $value1);
         $this->assertTrue($this->valkey_glide->move($key1, 1));
 
         // Verify key moved
         $this->assertEquals(0, $this->valkey_glide->exists($key1)); // Gone from db 0
-        $this->valkey_glide->select(1);
-        $this->assertKeyEquals($value1, $key1); // Present in db 1
+        // Verification disabled until select() command is supported.
+//        $this->valkey_glide->select(1);
+//        $this->assertKeyEquals($value1, $key1); // Present in db 1
     }
 
     public function testBlmove()
@@ -2551,12 +2552,12 @@ public function testInfoCommandStats()
         }
     }
 
-    public function testSelect()
+/*    public function testSelect()
     {
         $this->assertFalse(@$this->valkey_glide->select(-1));
         $this->assertTrue($this->valkey_glide->select(0));
     }
-
+*/
 
 
     public function testMset()
@@ -5689,7 +5690,7 @@ public function testEvalSHA()
     public function testClient()
     {
         /* CLIENT SETNAME */
-        $this->assertTrue($this->valkey_glide->client('setname', 'phpredis_unit_tests'));
+//        $this->assertTrue($this->valkey_glide->client('setname', 'phpredis_unit_tests'));
 
         /* CLIENT LIST */
         $clients = $this->valkey_glide->client('list');
@@ -5704,10 +5705,10 @@ public function testClient()
         }
 
         // We should have found our connection
-        $this->assertIsString($address);
+//        $this->assertIsString($address);
 
         /* CLIENT GETNAME */
-        $this->assertEquals('phpredis_unit_tests', $this->valkey_glide->client('getname'));
+//        $this->assertEquals('phpredis_unit_tests', $this->valkey_glide->client('getname'));
 
         if (version_compare($this->version, '5.0.0') >= 0) {
             $this->assertGT(0, $this->valkey_glide->client('id'));
@@ -5724,7 +5725,7 @@ public function testClient()
         }
 
         /* CLIENT KILL -- phpredis will reconnect, so we can do this */
-        $this->assertTrue($this->valkey_glide->client('kill', $address));
+//        $this->assertTrue($this->valkey_glide->client('kill', $address));
     }
 
 
@@ -5796,7 +5797,7 @@ public function testConfig()
         $this->assertFalse(@$this->valkey_glide->config('set', [0, 1, 2]));
     }
 
-    public function testReconnectSelect()
+/*    public function testReconnectSelect()
     {
         $key = 'reconnect-select';
         $value = 'Has been set!';
@@ -5827,7 +5828,7 @@ public function testReconnectSelect()
         // Revert the setting.
         $this->valkey_glide->config('SET', 'timeout', $original_cfg['timeout']);
     }
-
+*/
     public function testTime()
     {
         if (version_compare($this->version, '2.5.0') < 0) {

valkey_glide.stub.php

@@ -2333,7 +2333,7 @@ public function scard(string $key): ValkeyGlide|int|false;
      *
      * @example $valkey_glide->select(1);
      */
-    public function select(int $db): ValkeyGlide|bool;
+// public function select(int $db): ValkeyGlide|bool;
 
     /**
      * Create or set a ValkeyGlide STRING key to a value.

valkey_glide_commands_3.c

@@ -1458,9 +1458,9 @@ int execute_client_command_internal(
             command_type = ClientGetName;
         else if (strcasecmp(subcmd, "ID") == 0)
             command_type = ClientId;
-        else if (strcasecmp(subcmd, "SETNAME") == 0) {
-            command_type = ClientSetName;
-        } else if (strcasecmp(subcmd, "PAUSE") == 0)
+        //        else if (strcasecmp(subcmd, "SETNAME") == 0)
+        //            command_type = ClientSetName;
+        else if (strcasecmp(subcmd, "PAUSE") == 0)
             command_type = ClientPause;
         else if (strcasecmp(subcmd, "UNPAUSE") == 0)
             command_type = ClientUnpause;