Skip to content

Commit 31dfe0d

Browse files
committed
Add comments for not-yet-supported constructor features
1 parent f6e136d commit 31dfe0d

File tree

3 files changed

+14
-18
lines changed

3 files changed

+14
-18
lines changed

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,6 @@ try {
176176
$addresses, // addresses
177177
false, // use_tls
178178
null, // credentials
179-
ValkeyGlide::READ_FROM_PRIMARY, // read_from (PRIMARY)
180-
500 // request_timeout (500ms)
181179
);
182180
183181
// Basic operations
@@ -216,8 +214,6 @@ try {
216214
$addresses, // addresses
217215
false, // use_tls
218216
null, // credentials
219-
ValkeyGlide::READ_FROM_PRIMARY, // read_from (PRIMARY)
220-
500 // request_timeout (500ms)
221217
);
222218
223219
// Basic operations

valkey_glide.stub.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,13 @@ class ValkeyGlide
224224
* @param array $addresses Array of server addresses [['host' => 'localhost', 'port' => 6379], ...]
225225
* @param bool $use_tls Whether to use TLS encryption
226226
* @param array|null $credentials Authentication credentials ['password' => 'xxx', 'username' => 'yyy']
227-
* @param int $read_from Read strategy for the client
228-
* @param int|null $request_timeout Request timeout in milliseconds
229-
* @param array|null $reconnect_strategy Reconnection strategy ['num_of_retries' => 3, 'factor' => 2, ...]
230-
* @param int|null $database_id Database ID to select (0-15)
231-
* @param string|null $client_name Client name identifier
232-
* @param int|null $inflight_requests_limit Maximum number of concurrent requests
233-
* @param string|null $client_az Client availability zone
227+
* @param int $read_from Read strategy for the client (Not yet supported.)
228+
* @param int|null $request_timeout Request timeout in milliseconds (Not yet supported.)
229+
* @param array|null $reconnect_strategy Reconnection strategy ['num_of_retries' => 3, 'factor' => 2, ...] (Not yet supported.)
230+
* @param int|null $database_id Database ID to select (0-15) (Not yet supported.)
231+
* @param string|null $client_name Client name identifier (Not yet supported.)
232+
* @param int|null $inflight_requests_limit Maximum number of concurrent requests (Not yet supported.)
233+
* @param string|null $client_az Client availability zone (Not yet supported.)
234234
* @param array|null $advanced_config Advanced configuration ['connection_timeout' => 5000, 'tls_config' => [...]]
235235
* @param bool|null $lazy_connect Whether to use lazy connection
236236
*/

valkey_glide_cluster.stub.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ class ValkeyGlideCluster
9999
* @param array $addresses Array of server addresses [['host' => '127.0.0.1', 'port' => 7001], ...]
100100
* @param bool $use_tls Whether to use TLS encryption
101101
* @param array|null $credentials Authentication credentials ['password' => 'xxx', 'username' => 'yyy']
102-
* @param int $read_from Read strategy for the client
103-
* @param int|null $request_timeout Request timeout in milliseconds
104-
* @param array|null $reconnect_strategy Reconnection strategy ['num_of_retries' => 3, 'factor' => 2, ...]
105-
* @param string|null $client_name Client name identifier
106-
* @param int|null $periodic_checks Periodic checks configuration
107-
* @param int|null $inflight_requests_limit Maximum number of concurrent requests
108-
* @param string|null $client_az Client availability zone
102+
* @param int $read_from Read strategy for the client (Not yet supported.)
103+
* @param int|null $request_timeout Request timeout in milliseconds (Not yet supported.)
104+
* @param array|null $reconnect_strategy Reconnection strategy ['num_of_retries' => 3, 'factor' => 2, ...] (Not yet supported.)
105+
* @param string|null $client_name Client name identifier (Not yet supported.)
106+
* @param int|null $periodic_checks Periodic checks configuration (Not yet supported.)
107+
* @param int|null $inflight_requests_limit Maximum number of concurrent requests (Not yet supported.)
108+
* @param string|null $client_az Client availability zone (Not yet supported.)
109109
* @param array|null $advanced_config Advanced configuration ['connection_timeout' => 5000, 'tls_config' => [...]]
110110
* @param bool|null $lazy_connect Whether to use lazy connection
111111
*/

0 commit comments

Comments
 (0)