Skip to content

Commit a903be9

Browse files
committed
Update README.md and DEVELOPER.md with accurate setup instructions
Signed-off-by: Thomas Zhou <[email protected]>
1 parent 4105f30 commit a903be9

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

DEVELOPER.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Continue with **Install protobuf compiler** and **Install `ziglang` and `zigbuil
6969

7070
```bash
7171
brew update
72-
brew install php git gcc make autoconf automake libtool pkgconfig protobuf@3 openssl
72+
brew install php git gcc make autoconf automake libtool pkgconfig protobuf openssl
7373
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
7474
source "$HOME/.cargo/env"
7575
# Check that the Rust compiler is installed
@@ -81,12 +81,13 @@ rustc --version
8181
To install protobuf for MacOS, run:
8282

8383
```bash
84-
brew install protobuf@3
84+
brew install protobuf
85+
brew link protobuf
8586
# Verify the Protobuf compiler installation
8687
protoc --version
8788

8889
# If protoc is not found or does not work correctly, update the PATH
89-
echo 'export PATH="/opt/homebrew/opt/protobuf@3/bin:$PATH"' >> /Users/$USER/.bash_profile
90+
echo 'export PATH="/opt/homebrew/opt/protobuf/bin:$PATH"' >> /Users/$USER/.bash_profile
9091
source /Users/$USER/.bash_profile
9192
protoc --version
9293
```
@@ -121,7 +122,7 @@ Before starting this step, make sure you've installed all software requirements.
121122
cd valkey-glide-php
122123
```
123124

124-
1a. Initialize submodules (if not cloned with --recurse-submodules):
125+
1a. Initialize submodules (if not cloned with --recurse-submodules):
125126

126127
```bash
127128
git submodule update --init --recursive
@@ -148,15 +149,12 @@ Before starting this step, make sure you've installed all software requirements.
148149

149150
```bash
150151
# Configure with Valkey Glide support enabled
151-
./configure --enable-valkey-glide
152+
./configure
152153
```
153154

154155
5. Build the extension:
155156

156157
```bash
157-
# Pre-build step to prepare modules
158-
make generate-bindings generate-proto
159-
160158
# Build the extension
161159
make
162160
```

README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ source "$HOME/.cargo/env"
104104
```bash
105105
brew install protobuf
106106
brew install protobuf-c
107+
brew link protobuf
107108
# Verify installation
108109
protoc --version
109110
```
@@ -142,8 +143,8 @@ protoc --version
142143
4. Build the extension:
143144
```bash
144145
phpize
145-
./configure --enable-valkey-glide
146-
make build-modules-pre
146+
./configure
147+
make
147148
make install
148149
```
149150

@@ -166,6 +167,9 @@ protoc --version
166167
```
167168
make test
168169
```
170+
171+
Note: For fresh builds and installations, you may encounter permission issues. To resolve them, either adjust directory permissions or run the command with `sudo`
172+
169173
## Basic Examples
170174

171175
### Standalone Valkey:

0 commit comments

Comments
 (0)