Function support (#23)

* update CI

Signed-off-by: asafpamzn <[email protected]>
Signed-off-by: asafpamzn <[email protected]>

* Update ValkeyGlideClusterFeaturesTest.php

Reduce loop count

Signed-off-by: Asaf Porat Stoler <[email protected]>
Signed-off-by: asafpamzn <[email protected]>
Signed-off-by: asafpamzn <[email protected]>

* revert test change

Signed-off-by: asafpamzn <[email protected]>
Signed-off-by: asafpamzn <[email protected]>

* Enable logger

Signed-off-by: asafpamzn <[email protected]>

* Update error handling

Signed-off-by: asafpamzn <[email protected]>

* Update request timeout exceeded test (#21)

Fix testing request timeout in cluster tests to evaluate an error code
instead of expecting an exception.

Signed-off-by: James Duong <[email protected]>
Signed-off-by: asafpamzn <[email protected]>

* Function support

Signed-off-by: asafpamzn <[email protected]>

* Function support

Signed-off-by: asafpamzn <[email protected]>

* Fixed function based on comment on PR

Signed-off-by: asafpamzn <[email protected]>

---------

Signed-off-by: asafpamzn <[email protected]>
Signed-off-by: asafpamzn <[email protected]>
Signed-off-by: Asaf Porat Stoler <[email protected]>
Signed-off-by: James Duong <[email protected]>
Co-authored-by: James Duong <[email protected]>

Author: asafpamzn

command_response.c

@@ -691,11 +691,32 @@ int command_response_to_zval(CommandResponse* response,
             }
             // printf("%s:%d - DEBUG: Finished processing array response\n", __FILE__, __LINE__);
             return 1;
-#if 1
+
         case Map:
             // printf("%s:%d - CommandResponse is Map with length: %ld\n", __FILE__, __LINE__,
             // response->array_value_len);
             array_init(output);
+
+            // Special handling for FUNCTION command - skip server address wrapper
+            if (use_associative_array == COMMAND_RESPONSE_ASSOSIATIVE_ARRAY_MAP_FUNCTION &&
+                response->array_value_len == 1) {
+                CommandResponse* element = &response->array_value[0];
+                // Remove the first field of server address (contains ":")
+                if (element->map_key != NULL && element->map_key->response_type == String) {
+                    char* key_str = element->map_key->string_value;
+                    if (strchr(key_str, ':') != NULL) {
+                        // Skip the server key and process only the value
+                        if (element->map_value != NULL) {
+                            return command_response_to_zval(element->map_value,
+                                                            output,
+                                                            use_associative_array,
+                                                            use_false_if_null);
+                        }
+                    }
+                }
+            }
+
+            // Normal Map processing
             for (int i = 0; i < response->array_value_len; i++) {
                 zval             key, value;
                 CommandResponse* element = &response->array_value[i];
@@ -733,7 +754,7 @@ int command_response_to_zval(CommandResponse* response,
             }
             // php_var_dump(output, 2); // No need to modify this as it's not printf
             return 1;
-#endif
+
         case Sets:
             array_init(output);
             for (int i = 0; i < response->sets_value_len; i++) {

command_response.h

@@ -29,7 +29,9 @@ enum CommandResponseToZvalFlags {
     COMMAND_RESPONSE_ASSOSIATIVE_ARRAY_MAP = 1,  // Use associative array format for Map elements
     COMMAND_RESPONSE_STREAM_ARRAY_ASSOCIATIVE =
         2,  // Use associative array format for stream entries
-    COMMAND_RESPONSE_SCAN_ASSOSIATIVE_ARRAY = 3
+    COMMAND_RESPONSE_SCAN_ASSOSIATIVE_ARRAY = 3,
+    COMMAND_RESPONSE_ASSOSIATIVE_ARRAY_MAP_FUNCTION =
+        4  // Use associative array format for FUNCTION command responses
 };
 /*
  * Execute a command and handle common error checking

tests/ValkeyGlideTest.php

@@ -7073,12 +7073,6 @@ protected function testRequiresMode(string $mode)
         }
     }
 
-
-
-
-
-
-
     public function testCopy()
     {
         if (version_compare($this->version, '6.2.0') < 0) {
@@ -7102,7 +7096,6 @@ public function testCopy()
 
     public function testFunction()
     {
-        $this->markTestSkipped();// TODO support for functions is not implemented yet
         if (version_compare($this->version, '7.0') < 0) {
             $this->markTestSkipped();
         }

valkey_glide.stub.php

@@ -789,7 +789,7 @@ public function pexpiretime(string $key): ValkeyGlide|int|false;
      *
      * @see https://valkey.io/commands/fcall
      */
-    /* TODO public function fcall(string $fn, array $keys = [], array $args = []): mixed; */
+    public function fcall(string $fn, array $keys = [], array $args = []): mixed; 
 
     /**
      * This is a read-only variant of the FCALL command that cannot execute commands that modify data.
@@ -803,7 +803,7 @@ public function pexpiretime(string $key): ValkeyGlide|int|false;
      *
      * @see https://valkey.io/commands/fcall_ro
      */
-   /* TODO  public function fcall_ro(string $fn, array $keys = [], array $args = []): mixed; */
+    public function fcall_ro(string $fn, array $keys = [], array $args = []): mixed; 
 
     /**
      * Deletes every key in all ValkeyGlide databases
@@ -843,7 +843,7 @@ public function flushDB(?bool $sync = null): ValkeyGlide|bool;
      *
      * @see https://valkey.io/commands/function
      */
-    /* TODO public function function(string $operation, mixed ...$args): ValkeyGlide|bool|string|array; */
+    public function function(string $operation, mixed ...$args): ValkeyGlide|bool|string|array;
 
     /**
      * Add one or more members to a geospacial sorted set