Merge branch 'main' into task/add-scripting-commands

Signed-off-by: prashanna-frsh <prashanna.rajendran@freshworks.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: prashanna-frsh

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -2,7 +2,7 @@
 name: "🐛 Bug Report"
 description: Report a bug
 title: "(topic): (short issue description)"
-labels: [bug, needs-triage]
+labels: ["bug 🐞", "Untriaged user issue"]
 assignees: []
 body:
     - type: textarea

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -2,7 +2,7 @@
 name: 🚀 Feature Request
 description: Suggest an idea for this project
 title: "(topic): (short issue description)"
-labels: [feature-request, needs-triage]
+labels: ["Feature ✨", "Untriaged user issue"]
 assignees: []
 body:
     - type: textarea

.github/ISSUE_TEMPLATE/flaky-ci-test-issue.yml

@@ -1,7 +1,7 @@
 name: Flaky CI Test Issue
 description: Report a flaky test in the CI pipeline
 title: "[Flaky Test] <test-name>"
-labels: ["bug", "flaky-test"]
+labels: ["Flaky-tests 🐦", "CI/CD ⚒️"]
 assignees: []
 
 body:

.github/ISSUE_TEMPLATE/inquiry.yml

@@ -1,7 +1,7 @@
 name: Inquiry
 description: Use this template for asking questions
 title: "[Inquiry] "
-labels: ["Inquiry"]
+labels: ["Inquiry ❓"]
 assignees: []
 
 body:

.github/ISSUE_TEMPLATE/task.yml

@@ -1,7 +1,7 @@
 name: Task
 description: Create a task to manage work
 title: "[Task]"
-labels: ["task"]
+labels: ["Task 🔧"]
 assignees: []
 
 body:
@@ -21,8 +21,8 @@ body:
           label: Checklist
           description: Add items to be completed
           value: |
-              1. 
-              2. 
+              1.
+              2.
               ...
 
     - type: textarea

.github/dependabot.yml

@@ -18,7 +18,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "npm"
+          - "node 🐢"
 
     # Enable version updates for npm (Node client)
     - package-ecosystem: "npm"
@@ -37,8 +37,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "npm"
-          - "node"
+          - "node 🐢"
 
     # Enable version updates for Gradle (Java)
     - package-ecosystem: "gradle"
@@ -57,8 +56,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "gradle"
-          - "java"
+          - "java ☕"
 
     # Enable version updates for Cargo (Rust - glide-core)
     - package-ecosystem: "cargo"
@@ -77,8 +75,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
+          - "Rust ⚙️"
 
     # Enable version updates for Cargo (Rust - Java wrapper)
     - package-ecosystem: "cargo"
@@ -97,9 +94,8 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
-          - "java"
+          - "Rust ⚙️"
+          - "java ☕"
 
     # Enable version updates for Cargo (Rust - Python wrapper)
     - package-ecosystem: "cargo"
@@ -118,9 +114,8 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
-          - "python"
+          - "Rust ⚙️"
+          - "python 🐍"
 
     # Enable version updates for Go modules
     - package-ecosystem: "gomod"
@@ -139,7 +134,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "go"
+          - "go 🏃"
 
     # Enable version updates for pip (Python)
     - package-ecosystem: "pip"
@@ -158,8 +153,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "pip"
-          - "python"
+          - "python 🐍"
 
     # Enable version updates for GitHub Actions
     - package-ecosystem: "github-actions"

.github/workflows/dependabot-management.yml

@@ -73,7 +73,7 @@ jobs:
                   function parseDependabotTitle(title) {
                     const match = title.match(DEPENDABOT_TITLE_REGEX);
                     if (!match) return null;
-                    
+
                     const [, depName, fromVersion, toVersion] = match;
                     return { depName, fromVersion, toVersion };
                   }
@@ -89,27 +89,27 @@ jobs:
                   // Helper function to determine ecosystem label from PR branch
                   function getEcosystemLabel(pr) {
                     const branch = pr.head.ref;
-                    
+
                     // Extract ecosystem from dependabot branch name
                     // Pattern: dependabot/{ecosystem}/{dependency_name}-{version}
                     const branchMatch = branch.match(/^dependabot\/([^\/]+)\//);
                     if (branchMatch) {
                       const ecosystem = branchMatch[1];
-                      
+
                       // Map dependabot ecosystem names to our label conventions
                       const ecosystemMap = {
-                        'npm_and_yarn': 'npm',
-                        'npm': 'npm',
-                        'gradle': 'java',
-                        'cargo': 'rust',
-                        'gomod': 'go',
-                        'pip': 'python',
+                        'npm_and_yarn': 'node 🐢',
+                        'npm': 'node 🐢',
+                        'gradle': 'java ☕',
+                        'cargo': 'Rust ⚙️',
+                        'gomod': 'go 🏃',
+                        'pip': 'python 🐍',
                         'github_actions': 'github-actions'
                       };
-                      
+
                       return ecosystemMap[ecosystem] || ecosystem;
                     }
-                    
+
                     return null;
                   }
 
@@ -135,7 +135,7 @@ jobs:
 
                   async function processPR(pr) {
                     console.log(`\nProcessing PR #${pr.number}: ${pr.title}`);
-                    
+
                     // Parse the PR title to extract dependency info
                     const parsedTitle = parseDependabotTitle(pr.title);
                     if (!parsedTitle) {
@@ -169,7 +169,7 @@ jobs:
                     try {
                       const from = semver.coerce(fromVersion);
                       const to = semver.coerce(toVersion);
-                      
+
                       if (!from || !to) {
                         return 'unknown';
                       }
@@ -181,7 +181,7 @@ jobs:
                       } else if (semver.patch(from) !== semver.patch(to)) {
                         return 'patch';
                       }
-                      
+
                       return 'unknown';
                     } catch (error) {
                       console.log(`  Error determining update type: ${error.message}`);
@@ -210,7 +210,7 @@ jobs:
                         try {
                           const from = semver.coerce(fromVersion);
                           const to = semver.coerce(toVersion);
-                          
+
                           if (from && to && (semver.major(from) === 0 || semver.major(to) === 0)) {
                             console.log(`  0.x version detected - not auto-approving minor update`);
                             return false;
@@ -251,9 +251,9 @@ jobs:
 
                       // Add basic changelog information
                       const changelog = `## Changelog\n\nUpdated ${depName} from ${fromVersion} to ${toVersion}\n\n📋 To view detailed changes, visit the package repository or release notes.`;
-                      
+
                       const newBody = `${body}\n\n${changelog}`;
-                      
+
                       if (!dryRun) {
                         await octokit.rest.pulls.update({
                           owner,
@@ -273,7 +273,7 @@ jobs:
                   async function applyLabels(pr, updateType) {
                     try {
                       const labels = ['dependencies'];
-                      
+
                       // Add update type label
                       if (updateType !== 'unknown') {
                         labels.push(`dependency-${updateType}`);
@@ -311,7 +311,7 @@ jobs:
                       });
 
                       // Only allow auto-approval if all checks have concluded successfully
-                      const incompleteChecks = checks.check_runs.filter(check => 
+                      const incompleteChecks = checks.check_runs.filter(check =>
                         check.conclusion !== 'success' && check.conclusion !== 'skipped'
                       );
 
@@ -322,7 +322,7 @@ jobs:
                         const pendingChecks = incompleteChecks.filter(check =>
                           check.status === 'in_progress' || check.status === 'queued' || check.conclusion === null
                         );
-                        
+
                         if (failedChecks.length > 0) {
                           console.log(`  Cannot auto-approve - failed checks: ${failedChecks.map(c => c.name).join(', ')}`);
                         } else {

CHANGELOG.md

@@ -13,14 +13,17 @@
 * Python Sync: Add dynamic PubSub methods (subscribe, psubscribe, unsubscribe, punsubscribe, ssubscribe, sunsubscribe with timeout support), get_subscriptions(), and pubsub_reconciliation_interval configuration support. Unified configuration classes with async client by importing from glide_shared ([#5270](https://github.com/valkey-io/valkey-glide/pull/5270))
 * Go: Add dynamic PubSub methods (Subscribe, PSubscribe, SSubscribe, Unsubscribe, PUnsubscribe, SUnsubscribe with blocking variants and timeout support), GetSubscriptions(), and helper functions (UnsubscribeAll, PUnsubscribeAll, SUnsubscribeAll). Export pubsub constants (AllChannels, AllPatterns, AllShardedChannels)
 * JAVA: Add ACL server management commands (ACL CAT, ACL DELUSER, ACL DRYRUN, ACL GENPASS, ACL GETUSER, ACL LIST, ACL LOAD, ACL LOG, ACL SAVE, ACL SETUSER, ACL USERS, ACL WHOAMI)
+* Go: Add ACL server management commands (ACL CAT, ACL DELUSER, ACL DRYRUN, ACL GENPASS, ACL GETUSER, ACL LIST, ACL LOAD, ACL LOG, ACL LOGRESET, ACL SAVE, ACL SETUSER, ACL USERS, ACL WHOAMI)
 * CORE: Fix typo in ACL SETUSER command mapping (AclSetSser → AclSetUser)
 * Python: Add inflight request limit support to sync client
 * Python Sync: Add OpenTelemetry support with traces and metrics configuration
 * Python: Move OpenTelemetry config classes to glide_shared for code reuse between async and sync clients
 * JAVA: Add dynamic PubSub methods (subscribe, psubscribe, unsubscribe, punsubscribe, ssubscribe, sunsubscribe), getSubscriptions() for subscription state tracking, pubsubReconciliationIntervalMs configuration option, and subscription_out_of_sync_count and subscription_last_sync_timestamp metrics ([#5267](https://github.com/valkey-io/valkey-glide/issues/5267))
 * Go: Add ALLOW_NON_COVERED_SLOTS flag support for cluster scan ([#4895](https://github.com/valkey-io/valkey-glide/issues/4895))
+* CORE: Track HELLO and AUTH state for reconnection ([#5145](https://github.com/valkey-io/valkey-glide/issues/5145))
 
 #### Fixes
+* CORE: Fix empty hostname in CLUSTER SLOTS metadata causing AllConnectionsUnavailable ([#5367](https://github.com/valkey-io/valkey-glide/issues/5367)). AWS ElastiCache (plaintext, cluster mode) returns `hostname: ""` in node metadata, which was used as the connection address instead of falling back to the IP.
 * Node: Fix to handle non-string types in toBuffersArray ([#4842](https://github.com/valkey-io/valkey-glide/issues/4842))
 * CORE: Enforce connection_timeout for initial standalone connection failures  ([#4991](https://github.com/valkey-io/valkey-glide/issues/4991))
 * Node: Fixed `Failed to convert napi value Undefined into rust type u32` error  ([#5128](https://github.com/valkey-io/valkey-glide/pull/5128))

glide-core/redis-rs/redis/src/client.rs

@@ -7,7 +7,7 @@ use crate::{
     connection::{connect, Connection, ConnectionInfo, ConnectionLike, IntoConnectionInfo},
     push_manager::PushInfo,
     retry_strategies::RetryStrategy,
-    types::{RedisResult, Value},
+    types::{ProtocolVersion, RedisResult, Value},
 };
 #[cfg(feature = "aio")]
 use std::net::IpAddr;
@@ -602,6 +602,34 @@ impl Client {
     pub fn update_client_name(&mut self, client_name: Option<String>) {
         self.connection_info.redis.client_name = client_name;
     }
+
+    /// Updates the username in connection_info.
+    ///
+    /// This method updates the username field in the connection information,
+    /// which will be used for subsequent connections and reconnections.
+    /// Typically updated when AUTH command is used with a username.
+    ///
+    /// # Arguments
+    ///
+    /// * `username` - The username to use for authentication (None to clear)
+    ///
+    pub fn update_username(&mut self, username: Option<String>) {
+        self.connection_info.redis.username = username;
+    }
+
+    /// Updates the protocol version in connection_info.
+    ///
+    /// This method updates the protocol field in the connection information,
+    /// which will be used for subsequent connections and reconnections.
+    /// Typically updated when HELLO command is used to change protocol version.
+    ///
+    /// # Arguments
+    ///
+    /// * `protocol` - The protocol version to use (RESP2 or RESP3)
+    ///
+    pub fn update_protocol(&mut self, protocol: ProtocolVersion) {
+        self.connection_info.redis.protocol = protocol;
+    }
 }
 
 #[cfg(feature = "aio")]

glide-core/redis-rs/redis/src/cluster_async/mod.rs

@@ -85,6 +85,7 @@ use crate::{
         self, MultipleNodeRoutingInfo, Redirect, ResponsePolicy, Route, SingleNodeRoutingInfo,
     },
     push_manager::PushInfo,
+    types::ProtocolVersion,
     Cmd, ConnectionInfo, ErrorKind, IntoConnectionInfo, RedisError, RedisFuture, RedisResult,
     Value,
 };
@@ -356,6 +357,40 @@ where
             .await
     }
 
+    /// Update the username used to authenticate with all cluster servers
+    ///
+    /// This method updates the username for all cluster connections and stores it for future reconnections.
+    /// Typically called after a successful AUTH command with a username parameter.
+    ///
+    /// # Arguments
+    ///
+    /// * `username` - The username to use for authentication (None to clear)
+    ///
+    pub async fn update_connection_username(
+        &mut self,
+        username: Option<String>,
+    ) -> RedisResult<Value> {
+        self.route_operation_request(Operation::UpdateConnectionUsername(username))
+            .await
+    }
+
+    /// Update the protocol version used for all cluster connections
+    ///
+    /// This method updates the protocol version for all cluster connections and stores it for future reconnections.
+    /// Typically called after a successful HELLO command that changes the protocol version.
+    ///
+    /// # Arguments
+    ///
+    /// * `protocol` - The protocol version to use (RESP2 or RESP3)
+    ///
+    pub async fn update_connection_protocol(
+        &mut self,
+        protocol: ProtocolVersion,
+    ) -> RedisResult<Value> {
+        self.route_operation_request(Operation::UpdateConnectionProtocol(protocol))
+            .await
+    }
+
     /// Get the username used to authenticate with all cluster servers
     pub async fn get_username(&mut self) -> RedisResult<Value> {
         self.route_operation_request(Operation::GetUsername).await
@@ -683,6 +718,8 @@ enum Operation {
     UpdateConnectionPassword(Option<String>),
     UpdateConnectionDatabase(i64),
     UpdateConnectionClientName(Option<String>),
+    UpdateConnectionUsername(Option<String>),
+    UpdateConnectionProtocol(ProtocolVersion),
     GetUsername,
 }
 
@@ -2621,6 +2658,16 @@ where
                         .expect(MUTEX_WRITE_ERR);
                     Ok(Response::Single(Value::Okay))
                 }
+                Operation::UpdateConnectionUsername(username) => {
+                    core.set_cluster_param(|params| params.username = username)
+                        .expect(MUTEX_WRITE_ERR);
+                    Ok(Response::Single(Value::Okay))
+                }
+                Operation::UpdateConnectionProtocol(protocol) => {
+                    core.set_cluster_param(|params| params.protocol = protocol)
+                        .expect(MUTEX_WRITE_ERR);
+                    Ok(Response::Single(Value::Okay))
+                }
                 Operation::GetUsername => {
                     let username = match core
                         .get_cluster_param(|params| params.username.clone())