Merge branch 'main' into address-resolver

Signed-off-by: Gustavo Maciel <gmaciel@atlassian.com>

Author: tavomaciel

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -2,7 +2,7 @@
 name: "🐛 Bug Report"
 description: Report a bug
 title: "(topic): (short issue description)"
-labels: [bug, needs-triage]
+labels: ["bug 🐞", "Untriaged user issue"]
 assignees: []
 body:
     - type: textarea

.github/ISSUE_TEMPLATE/feature-request.yml

@@ -2,7 +2,7 @@
 name: 🚀 Feature Request
 description: Suggest an idea for this project
 title: "(topic): (short issue description)"
-labels: [feature-request, needs-triage]
+labels: ["Feature ✨", "Untriaged user issue"]
 assignees: []
 body:
     - type: textarea

.github/ISSUE_TEMPLATE/flaky-ci-test-issue.yml

@@ -1,7 +1,7 @@
 name: Flaky CI Test Issue
 description: Report a flaky test in the CI pipeline
 title: "[Flaky Test] <test-name>"
-labels: ["bug", "flaky-test"]
+labels: ["Flaky-tests 🐦", "CI/CD ⚒️"]
 assignees: []
 
 body:

.github/ISSUE_TEMPLATE/inquiry.yml

@@ -1,7 +1,7 @@
 name: Inquiry
 description: Use this template for asking questions
 title: "[Inquiry] "
-labels: ["Inquiry"]
+labels: ["Inquiry ❓"]
 assignees: []
 
 body:

.github/ISSUE_TEMPLATE/task.yml

@@ -1,7 +1,7 @@
 name: Task
 description: Create a task to manage work
 title: "[Task]"
-labels: ["task"]
+labels: ["Task 🔧"]
 assignees: []
 
 body:
@@ -21,8 +21,8 @@ body:
           label: Checklist
           description: Add items to be completed
           value: |
-              1. 
-              2. 
+              1.
+              2.
               ...
 
     - type: textarea

.github/dependabot.yml

@@ -18,7 +18,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "npm"
+          - "node 🐢"
 
     # Enable version updates for npm (Node client)
     - package-ecosystem: "npm"
@@ -37,8 +37,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "npm"
-          - "node"
+          - "node 🐢"
 
     # Enable version updates for Gradle (Java)
     - package-ecosystem: "gradle"
@@ -57,8 +56,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "gradle"
-          - "java"
+          - "java ☕"
 
     # Enable version updates for Cargo (Rust - glide-core)
     - package-ecosystem: "cargo"
@@ -77,8 +75,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
+          - "Rust ⚙️"
 
     # Enable version updates for Cargo (Rust - Java wrapper)
     - package-ecosystem: "cargo"
@@ -97,9 +94,8 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
-          - "java"
+          - "Rust ⚙️"
+          - "java ☕"
 
     # Enable version updates for Cargo (Rust - Python wrapper)
     - package-ecosystem: "cargo"
@@ -118,9 +114,8 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "cargo"
-          - "rust"
-          - "python"
+          - "Rust ⚙️"
+          - "python 🐍"
 
     # Enable version updates for Go modules
     - package-ecosystem: "gomod"
@@ -139,7 +134,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "go"
+          - "go 🏃"
 
     # Enable version updates for pip (Python)
     - package-ecosystem: "pip"
@@ -158,8 +153,7 @@ updates:
                   - "minor"
       labels:
           - "dependencies"
-          - "pip"
-          - "python"
+          - "python 🐍"
 
     # Enable version updates for GitHub Actions
     - package-ecosystem: "github-actions"

.github/workflows/dependabot-management.yml

@@ -73,7 +73,7 @@ jobs:
                   function parseDependabotTitle(title) {
                     const match = title.match(DEPENDABOT_TITLE_REGEX);
                     if (!match) return null;
-                    
+
                     const [, depName, fromVersion, toVersion] = match;
                     return { depName, fromVersion, toVersion };
                   }
@@ -89,27 +89,27 @@ jobs:
                   // Helper function to determine ecosystem label from PR branch
                   function getEcosystemLabel(pr) {
                     const branch = pr.head.ref;
-                    
+
                     // Extract ecosystem from dependabot branch name
                     // Pattern: dependabot/{ecosystem}/{dependency_name}-{version}
                     const branchMatch = branch.match(/^dependabot\/([^\/]+)\//);
                     if (branchMatch) {
                       const ecosystem = branchMatch[1];
-                      
+
                       // Map dependabot ecosystem names to our label conventions
                       const ecosystemMap = {
-                        'npm_and_yarn': 'npm',
-                        'npm': 'npm',
-                        'gradle': 'java',
-                        'cargo': 'rust',
-                        'gomod': 'go',
-                        'pip': 'python',
+                        'npm_and_yarn': 'node 🐢',
+                        'npm': 'node 🐢',
+                        'gradle': 'java ☕',
+                        'cargo': 'Rust ⚙️',
+                        'gomod': 'go 🏃',
+                        'pip': 'python 🐍',
                         'github_actions': 'github-actions'
                       };
-                      
+
                       return ecosystemMap[ecosystem] || ecosystem;
                     }
-                    
+
                     return null;
                   }
 
@@ -135,7 +135,7 @@ jobs:
 
                   async function processPR(pr) {
                     console.log(`\nProcessing PR #${pr.number}: ${pr.title}`);
-                    
+
                     // Parse the PR title to extract dependency info
                     const parsedTitle = parseDependabotTitle(pr.title);
                     if (!parsedTitle) {
@@ -169,7 +169,7 @@ jobs:
                     try {
                       const from = semver.coerce(fromVersion);
                       const to = semver.coerce(toVersion);
-                      
+
                       if (!from || !to) {
                         return 'unknown';
                       }
@@ -181,7 +181,7 @@ jobs:
                       } else if (semver.patch(from) !== semver.patch(to)) {
                         return 'patch';
                       }
-                      
+
                       return 'unknown';
                     } catch (error) {
                       console.log(`  Error determining update type: ${error.message}`);
@@ -210,7 +210,7 @@ jobs:
                         try {
                           const from = semver.coerce(fromVersion);
                           const to = semver.coerce(toVersion);
-                          
+
                           if (from && to && (semver.major(from) === 0 || semver.major(to) === 0)) {
                             console.log(`  0.x version detected - not auto-approving minor update`);
                             return false;
@@ -251,9 +251,9 @@ jobs:
 
                       // Add basic changelog information
                       const changelog = `## Changelog\n\nUpdated ${depName} from ${fromVersion} to ${toVersion}\n\n📋 To view detailed changes, visit the package repository or release notes.`;
-                      
+
                       const newBody = `${body}\n\n${changelog}`;
-                      
+
                       if (!dryRun) {
                         await octokit.rest.pulls.update({
                           owner,
@@ -273,7 +273,7 @@ jobs:
                   async function applyLabels(pr, updateType) {
                     try {
                       const labels = ['dependencies'];
-                      
+
                       // Add update type label
                       if (updateType !== 'unknown') {
                         labels.push(`dependency-${updateType}`);
@@ -311,7 +311,7 @@ jobs:
                       });
 
                       // Only allow auto-approval if all checks have concluded successfully
-                      const incompleteChecks = checks.check_runs.filter(check => 
+                      const incompleteChecks = checks.check_runs.filter(check =>
                         check.conclusion !== 'success' && check.conclusion !== 'skipped'
                       );
 
@@ -322,7 +322,7 @@ jobs:
                         const pendingChecks = incompleteChecks.filter(check =>
                           check.status === 'in_progress' || check.status === 'queued' || check.conclusion === null
                         );
-                        
+
                         if (failedChecks.length > 0) {
                           console.log(`  Cannot auto-approve - failed checks: ${failedChecks.map(c => c.name).join(', ')}`);
                         } else {

CHANGELOG.md

@@ -6,20 +6,21 @@
     * Node: Drop support for Node.js 16.x and 18.x. Minimum supported version is now Node.js 20.x.
 
 #### Changes
-
 * JAVA: Add EVAL_RO, EVALSHA_RO, and SCRIPT DEBUG commands ([#5125](https://github.com/valkey-io/valkey-glide/pull/5125))
 * CORE: Add client certificate and private key support for mTLS ([#5092](https://github.com/valkey-io/valkey-glide/issues/5092))
 * Python: Add client certificate and private key support for mTLS ([5123](https://github.com/valkey-io/valkey-glide/issues/5123))
 * JAVA: Add KEYS, MIGRATE and WAITAOF command support ([#5017](https://github.com/valkey-io/valkey-glide/pull/5107))
 * Python Sync: Add dynamic PubSub methods (subscribe, psubscribe, unsubscribe, punsubscribe, ssubscribe, sunsubscribe with timeout support), get_subscriptions(), and pubsub_reconciliation_interval configuration support. Unified configuration classes with async client by importing from glide_shared ([#5270](https://github.com/valkey-io/valkey-glide/pull/5270))
 * Go: Add dynamic PubSub methods (Subscribe, PSubscribe, SSubscribe, Unsubscribe, PUnsubscribe, SUnsubscribe with blocking variants and timeout support), GetSubscriptions(), and helper functions (UnsubscribeAll, PUnsubscribeAll, SUnsubscribeAll). Export pubsub constants (AllChannels, AllPatterns, AllShardedChannels)
 * JAVA: Add ACL server management commands (ACL CAT, ACL DELUSER, ACL DRYRUN, ACL GENPASS, ACL GETUSER, ACL LIST, ACL LOAD, ACL LOG, ACL SAVE, ACL SETUSER, ACL USERS, ACL WHOAMI)
+* Go: Add ACL server management commands (ACL CAT, ACL DELUSER, ACL DRYRUN, ACL GENPASS, ACL GETUSER, ACL LIST, ACL LOAD, ACL LOG, ACL LOGRESET, ACL SAVE, ACL SETUSER, ACL USERS, ACL WHOAMI)
 * CORE: Fix typo in ACL SETUSER command mapping (AclSetSser → AclSetUser)
 * Python: Add inflight request limit support to sync client
 * Python Sync: Add OpenTelemetry support with traces and metrics configuration
 * Python: Move OpenTelemetry config classes to glide_shared for code reuse between async and sync clients
 * JAVA: Add dynamic PubSub methods (subscribe, psubscribe, unsubscribe, punsubscribe, ssubscribe, sunsubscribe), getSubscriptions() for subscription state tracking, pubsubReconciliationIntervalMs configuration option, and subscription_out_of_sync_count and subscription_last_sync_timestamp metrics ([#5267](https://github.com/valkey-io/valkey-glide/issues/5267))
 * Go: Add ALLOW_NON_COVERED_SLOTS flag support for cluster scan ([#4895](https://github.com/valkey-io/valkey-glide/issues/4895))
+* CORE: Track HELLO and AUTH state for reconnection ([#5145](https://github.com/valkey-io/valkey-glide/issues/5145))
 * CORE: Support custom socket address resolution when connecting to valkey ([#4396](https://github.com/valkey-io/valkey-glide/issues/4396))
 
 #### Fixes
@@ -29,6 +30,8 @@
 * Python: Fix Sphinx docs build failure with duplicate object warnings  ([#5163](https://github.com/valkey-io/valkey-glide/issues/5163))
 * Java: Restore shading and relocation of protobuf ([#5031](https://github.com/valkey-io/valkey-glide/pull/5031))
 * CORE: Remove DEFAULT_CLIENT_CREATION_TIMEOUT and honor user-provided connection timeout by centralizing timeout logic in ConnectionRequest ([#5183](https://github.com/valkey-io/valkey-glide/issues/5183))
+* Java: Fix mget large binary data issue and add test case ([#5341](https://github.com/valkey-io/valkey-glide/pull/5341))
+* Java: Fix resource leak in integration tests where clients created via @MethodSource were never closed ([#5347](https://github.com/valkey-io/valkey-glide/issues/5347))
 
 #### Operational Enhancements
 * Docs: Add missing references to windows-x86_64 classifier ([#5028](https://github.com/valkey-io/valkey-glide/pull/5028))

glide-core/redis-rs/redis/src/client.rs

@@ -7,7 +7,7 @@ use crate::{
     connection::{connect, Connection, ConnectionInfo, ConnectionLike, IntoConnectionInfo},
     push_manager::PushInfo,
     retry_strategies::RetryStrategy,
-    types::{RedisResult, Value},
+    types::{ProtocolVersion, RedisResult, Value},
 };
 #[cfg(feature = "aio")]
 use std::net::IpAddr;
@@ -602,6 +602,34 @@ impl Client {
     pub fn update_client_name(&mut self, client_name: Option<String>) {
         self.connection_info.redis.client_name = client_name;
     }
+
+    /// Updates the username in connection_info.
+    ///
+    /// This method updates the username field in the connection information,
+    /// which will be used for subsequent connections and reconnections.
+    /// Typically updated when AUTH command is used with a username.
+    ///
+    /// # Arguments
+    ///
+    /// * `username` - The username to use for authentication (None to clear)
+    ///
+    pub fn update_username(&mut self, username: Option<String>) {
+        self.connection_info.redis.username = username;
+    }
+
+    /// Updates the protocol version in connection_info.
+    ///
+    /// This method updates the protocol field in the connection information,
+    /// which will be used for subsequent connections and reconnections.
+    /// Typically updated when HELLO command is used to change protocol version.
+    ///
+    /// # Arguments
+    ///
+    /// * `protocol` - The protocol version to use (RESP2 or RESP3)
+    ///
+    pub fn update_protocol(&mut self, protocol: ProtocolVersion) {
+        self.connection_info.redis.protocol = protocol;
+    }
 }
 
 #[cfg(feature = "aio")]