Python sync: add update_connection_password (#4548)

implemented sync update_connection_password

Signed-off-by: Lior Sventitzky <liorsve@amazon.com>

Author: liorsve

python/glide-sync/glide_sync/glide_client.py

@@ -220,6 +220,12 @@ def _init_ffi(self):
                 unsigned long arg_count, const size_t *args, const unsigned long* args_len,
                 const unsigned char* route_bytes, size_t route_bytes_len, uint64_t span_ptr
             );
+            CommandResult* update_connection_password(
+                const void* client_adapter_ptr,
+                uintptr_t request_id,
+                const char* password,
+                bool immediate_authentication
+            );
         """
         )
 
@@ -403,6 +409,60 @@ def _execute_command(
         )
         return self._handle_cmd_result(result)
 
+    def _update_connection_password(
+        self,
+        password: Optional[str],
+        immediate_auth: bool = False,
+    ) -> TResult:
+        """
+        Update the current connection password with a new password.
+
+        Note:
+            This method updates the client's internal password configuration and does
+            not perform password rotation on the server side.
+
+        This method is useful in scenarios where the server password has changed or when
+        utilizing short-lived passwords for enhanced security. It allows the client to
+        update its password to reconnect upon disconnection without the need to recreate
+        the client instance. This ensures that the internal reconnection mechanism can
+        handle reconnection seamlessly, preventing the loss of in-flight commands.
+
+        Args:
+            password (`Optional[str]`): The new password to use for the connection,
+                if `None` the password will be removed.
+            immediate_auth (`bool`):
+                `True`: The client will authenticate immediately with the new password against all connections, Using `AUTH`
+                command. If password supplied is an empty string, auth will not be performed and warning will be returned.
+                The default is `False`.
+
+        Returns:
+            TOK: A simple OK response. If `immediate_auth=True` returns OK if the reauthenticate succeed.
+
+        Example:
+            >>> client.update_connection_password("new_password", immediate_auth=True)
+            'OK'
+        """
+        if self._is_closed:
+            raise ClosingError("Client is closed.")
+        client_adapter_ptr = self._core_client
+        if client_adapter_ptr == self._ffi.NULL:
+            raise ValueError("Invalid client pointer.")
+
+        # Prepare C string for password
+        c_password = (
+            self._ffi.new("char[]", password.encode(ENCODING))
+            if password is not None
+            else self._ffi.new("char[]", b"")
+        )
+
+        result = self._lib.update_connection_password(
+            client_adapter_ptr,
+            0,  # Request ID (0 for sync use)
+            c_password,
+            immediate_auth,
+        )
+        return self._handle_cmd_result(result)
+
     def close(self):
         if not self._is_closed:
             self._lib.close_client(self._core_client)

python/tests/async_tests/conftest.py

@@ -90,7 +90,7 @@ async def acl_glide_client(
     """
     Client fot tests that use a server pre-configured with an ACL user.
     This function first uses the management client to register the USERNAME with INITIAL_PASSWORD,so that
-    the client would be ablt to connect.
+    the client would be able to connect.
     It then returns a client with this USERNAME and INITIAL_PASSWORD already set as its ServerCredentials.
     """
 

python/tests/sync_tests/conftest.py

@@ -17,10 +17,13 @@
 
 from tests.utils.cluster import ValkeyCluster
 from tests.utils.utils import (
+    INITIAL_PASSWORD,
     NEW_PASSWORD,
+    USERNAME,
     auth_client,
     config_set_new_password,
     create_sync_client_config,
+    set_new_acl_username_with_password,
 )
 
 
@@ -37,6 +40,60 @@ def glide_sync_client(
     client.close()
 
 
+@pytest.fixture(scope="function")
+def management_sync_client(
+    request,
+    cluster_mode: bool,
+    protocol: ProtocolVersion,
+) -> Generator[TSyncGlideClient, None, None]:
+    """Get async socket client for tests, used to manage the state when tests are on the client ability to connect"""
+    client = create_sync_client(
+        request, cluster_mode, protocol=protocol, lazy_connect=False
+    )
+    try:
+        yield client
+    finally:
+        # Close the client first, then run teardown
+        client.close()
+        # Run teardown which has its own robust error handling
+        sync_test_teardown(request, cluster_mode, protocol)
+
+
+@pytest.fixture(scope="function")
+def acl_glide_sync_client(
+    request,
+    cluster_mode: bool,
+    protocol: ProtocolVersion,
+    management_sync_client: TSyncGlideClient,
+) -> Generator[TSyncGlideClient, None, None]:
+    """
+    Client fot tests that use a server pre-configured with an ACL user.
+    This function first uses the management client to register the USERNAME with INITIAL_PASSWORD,so that
+    the client would be able to connect.
+    It then returns a client with this USERNAME and INITIAL_PASSWORD already set as its ServerCredentials.
+    """
+
+    set_new_acl_username_with_password(
+        management_sync_client, USERNAME, INITIAL_PASSWORD
+    )
+
+    client = create_sync_client(
+        request,
+        cluster_mode,
+        protocol=protocol,
+        credentials=ServerCredentials(username=USERNAME, password=INITIAL_PASSWORD),
+        request_timeout=2000,
+        lazy_connect=False,
+    )
+    try:
+        yield client
+    finally:
+        # Close the client first, then run teardown
+        client.close()
+        # Run teardown which has its own robust error handling
+        sync_test_teardown(request, cluster_mode, protocol)
+
+
 def create_sync_client(
     request,
     cluster_mode: bool,