You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: go/DEVELOPER.md
+17-14Lines changed: 17 additions & 14 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -47,6 +47,9 @@ source "$HOME/.cargo/env"
47
47
rustc --version
48
48
```
49
49
50
+
> [!NOTE]
51
+
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
52
+
50
53
Continue with **Install protobuf compiler** and **Install `ziglang` and `zigbuild`** below.
51
54
52
55
**Dependencies installation for CentOS**
@@ -66,36 +69,33 @@ source "$HOME/.cargo/env"
66
69
rustc --version
67
70
```
68
71
72
+
> [!NOTE]
73
+
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
74
+
69
75
Continue with **Install protobuf compiler** and **Install `ziglang` and `zigbuild`** below.
70
76
71
77
**Dependencies installation for MacOS**
72
78
73
79
```bash
74
80
brew update
75
-
brew install go make git gcc pkgconfig protobuf@3 openssl cmake
81
+
brew install go make git gcc pkgconfig openssl cmake
76
82
export PATH="$PATH:$HOME/go/bin"
77
83
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
78
84
source"$HOME/.cargo/env"
79
85
# Check that the Rust compiler is installed
80
86
rustc --version
81
87
```
82
88
83
-
**Install protobuf compiler**
89
+
> [!NOTE]
90
+
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
84
91
85
-
To install protobuf for MacOS, run:
86
-
87
-
```bash
88
-
brew install protobuf@3
89
-
# Verify the Protobuf compiler installation
90
-
protoc --version
92
+
Continue with **Install protobuf compiler** below.
93
+
It is not necessary to **Install `ziglang` and `zigbuild`** for MacOS.
91
94
92
-
# If protoc is not found or does not work correctly, update the PATH
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
88
+
90
89
**Install `ziglang` and `zigbuild`**
91
90
92
91
```bash
@@ -174,7 +173,6 @@ Some troubleshooting issues:
174
173
you may need to restart your machine. In particular, this may solve the following problems:
175
174
- Failed to find `cargo` after `rustup`.
176
175
- No Protobuf compiler (protoc) found.
177
-
- If protobuf 29.0 or earlier is detected, upgrade to the latest protobuf release.
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
35
35
source"$HOME/.cargo/env"
36
36
# Check the installed node version
37
37
node -v
38
38
```
39
39
40
-
> **Note:** Ensure that you installed a supported Node.js version. For Ubuntu 22.04 or earlier, please refer to the instructions [here](#note-nodejs-supported-version) to upgrade your Node.js version.
40
+
Continue with **Install protobuf compiler** below.
41
+
42
+
> [!NOTE]
43
+
> Ensure that you installed a supported Node.js version. For Ubuntu 22.04 or earlier, please refer to the instructions [here](#note-nodejs-supported-version) to upgrade your Node.js version.
# Check that the protobuf compiler is installed. A minimum version of 3.20.0 is required.
78
+
protoc --version
79
+
```
80
+
81
+
> [!NOTE]
82
+
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
83
+
60
84
**Valkey Server and CLI**
61
85
See the [Valkey installation guide](https://valkey.io/topics/installation/) to install the Valkey server and CLI.
> You may wish to add the entire `export PATH` line to your shell configuration file to persist this path addition, either `.bashrc` or `.zshrc` depending on which shell you are using.
154
+
162
155
</details>
163
156
164
157
<details>
@@ -358,7 +351,7 @@ This section explains how the `valkey-glide` (async client) and `valkey-glide-sy
358
351
359
352
> By default, `mkdocs` should still be using Google's Python Docstring Style so the "Documentation Style" section below will still be valid.
360
353
361
-
We follow the [Google Style Python Docstrings format](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html) in our documentation. For our documentation tool, we use `sphinx`.
354
+
We follow the [Google Style Python Docstrings format](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html) in our documentation. For our documentation tool, we use `sphinx`.
362
355
363
356
**Note:**`docs/index.rst` has manual modifications to it and should NOT be deleted. Modify this file with caution.
364
357
@@ -424,7 +417,7 @@ Examples:
424
417
"""
425
418
```
426
419
427
-
### Example of Properly Formatted Documentation for a Class
420
+
### Example of Properly Formatted Documentation for a Class
428
421
429
422
```python
430
423
class BitOffsetMultiplier(BitFieldOffset):
@@ -495,7 +488,7 @@ Attributes:
495
488
496
489
#### Return value(s)
497
490
498
-
Return values are a little special for sphinx. If we wanted to provide more context or multiple possible return values, the convention we will go for is that we should add a space between every different return value.
491
+
Return values are a little special for sphinx. If we wanted to provide more context or multiple possible return values, the convention we will go for is that we should add a space between every different return value.
499
492
500
493
We start by adding the returntype on the first line, followed by a description of the return value.
501
494
@@ -504,10 +497,10 @@ We start by adding the return type on the first line, followed by a description
504
497
```python
505
498
Returns:
506
499
List[int]: Some description here regarding the purpose of the list of ints being
507
-
returned. Notice how this new line is not indented but it is still apart of the same
500
+
returned. Notice how this new line is not indented but it is still apart of the same
508
501
description.
509
502
510
-
If we ever want to provide more context or another description of another return value
503
+
If we ever want to provide more context or another description of another return value
511
504
(ex. None, -1, True/False, etc.) we add a space between this description and the
512
505
previous description.
513
506
```
@@ -551,7 +544,7 @@ Examples:
551
544
}
552
545
# Indicates the stream entries for "my_stream" with IDs greater than "0-0". The operation blocks up to
0 commit comments