Merge pull request #153 from valkey-io/aiven-sal/url

Allow relative path in unix socket URLs

Author: aiven-sal

tests/test_connection.py

@@ -341,3 +341,10 @@ def test_unix_socket_connection_failure():
         str(e.value)
         == "Error 2 connecting to unix:///tmp/a.sock. No such file or directory."
     )
+
+
+def test_parsing_unix_socket_relative_path():
+    parsed = parse_url("unix:./valkey.sock", False)
+    assert parsed["path"] == "./valkey.sock"
+    assert parsed["connection_class"] is UnixDomainSocketConnection
+    assert len(parsed) == 2

valkey/_parsers/url_parser.py

@@ -40,10 +40,11 @@ def parse_url(url: str, async_connection: bool):
     supported_schemes = ["valkey", "valkeys", "redis", "rediss", "unix"]
     parsed: ParseResult = urlparse(url)
     kwargs: ConnectKwargs = {}
+    lower_url = url.lower()
     pattern = re.compile(
-        r"^(?:" + "|".join(map(re.escape, supported_schemes)) + r")://", re.IGNORECASE
+        r"^(?:" + "|".join(map(re.escape, supported_schemes)) + r")://"
     )
-    if not pattern.match(url):
+    if not pattern.match(lower_url) and not lower_url.startswith("unix:"):
         raise ValueError(
             f"Valkey URL must specify one of the following schemes {supported_schemes}"
         )