Allow relative path in unix socket URLs

aiven-sal · aiven-sal · commit 65b5c047bc7f · 2024-12-13T18:05:08.000+01:00
Close #123 Signed-off-by: Salvatore Mesoraca <salvatore.mesoraca@aiven.io>
diff --git a/valkey/_parsers/url_parser.py b/valkey/_parsers/url_parser.py
@@ -40,10 +40,11 @@ def parse_url(url: str, async_connection: bool):
     supported_schemes = ["valkey", "valkeys", "redis", "rediss", "unix"]
     parsed: ParseResult = urlparse(url)
     kwargs: ConnectKwargs = {}
+    lower_url = url.lower()
     pattern = re.compile(
-        r"^(?:" + "|".join(map(re.escape, supported_schemes)) + r")://", re.IGNORECASE
+        r"^(?:" + "|".join(map(re.escape, supported_schemes)) + r")://"
     )
-    if not pattern.match(url):
+    if not pattern.match(lower_url) and not lower_url.startswith("unix:"):
         raise ValueError(
             f"Valkey URL must specify one of the following schemes {supported_schemes}"
         )

Original file line number	Diff line number	Diff line change
`@@ -40,10 +40,11 @@ def parse_url(url: str, async_connection: bool):`
`40`	`40`	`supported_schemes = ["valkey", "valkeys", "redis", "rediss", "unix"]`
`41`	`41`	`parsed: ParseResult = urlparse(url)`
`42`	`42`	`kwargs: ConnectKwargs = {}`
	`43`	`+ lower_url = url.lower()`
`43`	`44`	`pattern = re.compile(`
`44`		`- r"^(?:" + "\|".join(map(re.escape, supported_schemes)) + r")://", re.IGNORECASE`
	`45`	`+ r"^(?:" + "\|".join(map(re.escape, supported_schemes)) + r")://"`
`45`	`46`	`)`
`46`		`- if not pattern.match(url):`
	`47`	`+ if not pattern.match(lower_url) and not lower_url.startswith("unix:"):`
`47`	`48`	`raise ValueError(`
`48`	`49`	`f"Valkey URL must specify one of the following schemes {supported_schemes}"`
`49`	`50`	`)`