Skip to content

Commit 2e8fba4

Browse files
authored
[Test Fix] flaky benchmark test for warmup (#2890)
Fixes: #2859 Increased the warmup to 2 sec so we can verify that it runs more number of commands than the actual benchmark. Signed-off-by: Roshan Khatri <[email protected]>
1 parent 1b5f245 commit 2e8fba4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tests/integration/valkey-benchmark.tcl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,13 +248,13 @@ tags {"benchmark network external:skip logreqres:skip"} {
248248

249249
test {benchmark: warmup applies to all tests in multi-test run} {
250250
set start_time [clock clicks -millisec]
251-
set cmd [valkeybenchmark $master_host $master_port "-r 5 --warmup 1 -n 50 -t set,get,incr"]
251+
set cmd [valkeybenchmark $master_host $master_port "-r 5 --warmup 2 -n 50 -t set,get,incr"]
252252
set output [common_bench_setup $cmd]
253253
set end_time [clock clicks -millisec]
254254

255-
# Verify total duration includes warmup for all 3 tests (at least 3 seconds)
255+
# Verify total duration includes warmup for all 3 tests (at least 6 seconds)
256256
set elapsed [expr {($end_time - $start_time)/1000.0}]
257-
assert {$elapsed >= 3}
257+
assert {$elapsed >= 6}
258258

259259
# Verify all tests ran - with warmup, we expect more than 50 calls per command
260260
# since warmup commands are also counted in server stats

0 commit comments

Comments
 (0)