Skip to content

Commit 97f2678

Browse files
authored
fix(in-app-review): use split play core services (#12)
1 parent 0a95ced commit 97f2678

File tree

7 files changed

+1717
-8982
lines changed

7 files changed

+1717
-8982
lines changed

packages/nativescript-in-app-review/index.android.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export class InAppReview extends InAppReviewCommon {
99

1010
return new Promise<void>((resolve, reject) =>
1111
request.addOnCompleteListener(
12-
new com.google.android.play.core.tasks.OnCompleteListener({
12+
new com.google.android.gms.tasks.OnCompleteListener({
1313
onComplete: (task) => {
1414
if (!task.isSuccessful()) {
1515
reject(new Error(task.getException()?.getMessage()));
@@ -20,7 +20,7 @@ export class InAppReview extends InAppReviewCommon {
2020
const flow = manager.launchReviewFlow(Application.android.foregroundActivity, reviewInfo);
2121

2222
flow.addOnCompleteListener(
23-
new com.google.android.play.core.tasks.OnCompleteListener({
23+
new com.google.android.gms.tasks.OnCompleteListener({
2424
onComplete: (task) => {
2525
// The flow has finished. The API does not indicate whether the
2626
// user reviewed or not, or even whether the review dialog was
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
dependencies {
2-
implementation 'com.google.android.play:core:1.10.3'
2+
implementation 'com.google.android.play:review:2.0.1'
33
}
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
/// <reference path="../../references.d.ts" />
2-
/// <reference path="./types/play-core-android.d.ts" />
2+
/// <reference path="./types/play-review.d.ts" />
3+
/// <reference path="./types/play-services-tasks.d.ts" />

0 commit comments

Comments
 (0)